search

rethinkdb / rethinkdb_rebirth

The open-source database for the realtime web.
https://rethinkdb.com
Other
999 stars 42 forks source link

Remove Windows support. #3

Closed asakatida closed 6 years ago

asakatida commented 6 years ago

Current consensus from external discussion is that windows support should be removed. This will fix at least one test that is out of date and failing.

atris commented 6 years ago

Thanks

On Tue, May 29, 2018 at 1:01 AM, Adam Grandquist notifications@github.com wrote:

Assigned #3 https://github.com/RebirthDB/rebirthdb/issues/3 to @atris https://github.com/atris.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/RebirthDB/rebirthdb/issues/3#event-1649834182, or mute the thread https://github.com/notifications/unsubscribe-auth/ABpO46da5eGRu0iRdSVy5hmGB29f-DMsks5t3FCggaJpZM4UQiU_ .

-- Regards,

Atri l'apprenant

sankethpb commented 6 years ago

I am not an expert here, but it doesn't sound good to remove windows Support to fix a failing test. We use RethinkDB currently only on windows and request the community to continue the support.

maarteNNNN commented 6 years ago

@sankethpb Docker should solve your headache. Windows support isn't needed that much anymore.

PassTheMayo commented 6 years ago

Lots of people use RethinkDB (or Rebirth) on Windows because they own a Windows Server. This is a bad idea!

sankethpb commented 6 years ago

If the entire application is containerized then, docker is good but otherwise, just to host database (RethinkDB/RebirthDB) there will be too much overhead to setup and maintain docker, data persistence etc. Docker works fine only on latest Windows OS (10 and latest server), in older OS its complicated. Also like @PassTheMayo mentioned, Lots of people use RethinkDB (or Rebirth) on Windows because they own a Windows Server and currently very easy to setup.

@grandquista @atris @maarteNNNN @thelinuxlich It would be a bad idea to remove Windows support without a compelling reason. It would be great to fix the test or remove the test if it is not valid anymore rather than removing the support for Windows.

atris commented 6 years ago

Ok, if we have users who wish to have support for windows, we shall continue to have it. Thanks for chipping in.

On Thu, May 31, 2018 at 11:04 AM Sanketh P B notifications@github.com wrote:

If the entire application is containerized then, docker is good but otherwise, just to host database (RethinkDB/RebirthDB) there will be too much overhead to setup and maintain docker, data persistence etc. Docker works fine only on latest Windows OS (10 and latest server), in older OS its complicated. Also like @PassTheMayo https://github.com/PassTheMayo mentioned, Lots of people use RethinkDB (or Rebirth) on Windows because they own a Windows Server and currently very easy to setup.

@grandquista https://github.com/grandquista @atris https://github.com/atris @maarteNNNN https://github.com/maarteNNNN @thelinuxlich https://github.com/thelinuxlich It would be a bad idea to remove Windows support without a compelling reason. It would be great to fix the test or remove the test if it is not valid anymore rather than removing the support for Windows.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RebirthDB/rebirthdb/issues/3#issuecomment-393409591, or mute the thread https://github.com/notifications/unsubscribe-auth/ABpO4zB5dEwT7jUpLL6wHbIfkEFX3rh0ks5t34DsgaJpZM4UQiU_ .

-- Regards,

Atri l'apprenant

sankethpb commented 6 years ago

Thank you 👍

thelinuxlich commented 6 years ago

Actually we need to be smart about our resources if we want to keep a healthy release schedule. The Windows version always was beta quality and behind in stability. If no developer steps in to assume the responsibility of keeping the Windows support, we shouldn't postpone the release.

thelinuxlich commented 6 years ago

This issue should be reopened

atris commented 6 years ago

Agreed. However, we should look at easier migrations then. I wouldn't want to lose our Windows users

On Thu, May 31, 2018 at 11:19 AM Alisson Cavalcante Agiani notifications@github.com wrote:

Reopened #3.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

-- Regards,

Atri l'apprenant

thelinuxlich commented 6 years ago

So you will mantain the windows version?

thelinuxlich commented 6 years ago

We will probably stumble upon things we want to do which aren't compatible with Windows. Not to mention performance issues because of windows lack of fork(), etc

atris commented 6 years ago

I didnt say that :)

My two cents here are that we should make it easier for existing windows users to migrate to a Linux based system. I have personally never used Windows, so do not know whats the state there.

On Thu, May 31, 2018 at 11:35 AM Alisson Cavalcante Agiani < notifications@github.com> wrote:

So you will mantain the windows version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RebirthDB/rebirthdb/issues/3#issuecomment-393415332, or mute the thread https://github.com/notifications/unsubscribe-auth/ABpO4w4fM7t5ikm8W7bf_dJn1_90X1Ixks5t34g6gaJpZM4UQiU_ .

-- Regards,

Atri l'apprenant

atris commented 6 years ago

I agree with @thelinuxlich that we need a maintainer. If somebody steps in, we can continue to have the support, or we will be forced to drop it in 2.4

sankethpb commented 6 years ago

I could support in setting up Build system in Appveyor for windows

thelinuxlich commented 6 years ago

And the core engine code?

ronzeidman commented 6 years ago

Question for the windows edition supporters. I'm using the windows version mainly for development and I hate to use docker just for this but I tried now and the Ubuntu version works well on WSL. Can anyone test if there are considerable downsides of just using WSL (I'm guessing performance wise) instead of the windows version?

zugende commented 6 years ago

I second ronzeidman. When using WSL is equally good or even better then Windows or Docker I am all in removing Windows support. I use Windows version purely for development.

thelinuxlich commented 6 years ago

It is settled, we are removing it.

gdude2002 commented 6 years ago

I don't think that's really a great option until Windows 7 and Windows 8 are both entirely unsupported - so that'd be in 2023 (for Windows 8 anyway). After that, sure, why not? WSL is pretty great.

Sadly a lot of people either don't have machines that can handle Windows 10, or bought into the scaremongering and didn't take the free upgrade when they had the chance.

thelinuxlich commented 6 years ago

@gdude2002 we are short on core developers, so we have to be wise about what fish we can fry. That said, lack of windows support cannot hinder the release schedule