reticulatedpines / magiclantern_simplified

A Git based version of Magic Lantern, for those unwilling or unable to work using Mercurial. The vast majority of branches have been removed, with those thought to be important brought in individually and merged.
GNU General Public License v2.0
149 stars 51 forks source link

Fix bench module dependency on icache / dcache functions #91

Closed reticulatedpines closed 1 year ago

reticulatedpines commented 1 year ago

bench module depends on icache_unlock() and dcache_unlock() in mem_perf.c. These don't exist on ARMv7. We can't use a camera CONFIG define to guard this because modules aren't built in a camera context. This means bench doesn't get included on builds for modern cams because they fail the dep check.

From other modules, it appears the fix / bodge is to do something like this: extern WEAK_FUNC(ret_0) void raw_lv_request();

Work out the appropriate fake function to replace these with and check if this is an appropriate solution.

reticulatedpines commented 1 year ago

ret_0 is fine, fix is in https://github.com/reticulatedpines/magiclantern_simplified/commit/efbe32832b73a4e37fb234de56a7e2252992ceea