Allow Retis & its modules to check for prerequisites

retis-org / retis

Tracing packets in the Linux networking stack & friends

https://retis.readthedocs.io/en/stable/

100 stars 14 forks source link

Allow Retis & its modules to check for prerequisites #145

Closed atenart closed 1 year ago

atenart commented 1 year ago

In this PR:

The inspector is moved to its own crate, and reworked a bit for easier use.
New helpers are added to provide info on the kernel version, configuration, OS, loaded modules.
A match engine for the kernel version is provided.

This is a prerequisite for #100 and for #115. Current form should be good enough to use as a base for both PRs.

atenart commented 1 year ago

Added support for:

Modules to check for prerequisites. Now modules can fail and if the user didn't explicitly specify a list of modules we can auto-detect of modules can run. This makes retis collect to work on system not having ovs running.
Retis to check for prerequisites. This improves ux as we can detect early if Retis will be able to properly work, and if not we can fail and/or issue warnings with lengthy explanations.

Fixes #100.

amorenoz commented 1 year ago

In general, I'm pretty happy with the basic API so I'll rebase #115 on top and start working on it

amorenoz commented 1 year ago

I wanted to rebase #115 on top of this to test but it's proven complicated because it also breaks #155 . So I'd say we can merge this and I can fix any issue I find afterwards, wdty?

atenart commented 1 year ago

I wanted to rebase #115 on top of this to test but it's proven complicated because it also breaks #155 . So I'd say we can merge this and I can fix any issue I find afterwards, wdty?

Works for me.