search

retis-org / retis

Tracing packets in the Linux networking stack & friends
https://retis.readthedocs.io/en/stable/
100 stars 14 forks source link

ARP support #223

Closed atenart closed 1 year ago

atenart commented 1 year ago

Apart from some small comments I have a suggestion: how about a functional test? :-D

Yeah... I agree that would be nice and all but tbh it's unlikely I'll have time to make it part of that PR. That being said I started a local branch with skb runtime tests (currently only a sanity one) so with some luck that might be a reality in some time.

atenart commented 1 year ago

That being said I started a local branch with skb runtime tests (currently only a sanity one) so with some luck that might be a reality in some time.

Looks like your comment gave me some motivation to complete it so we at least have something running for the skb module (#226) :)

(Still, I'd like to add the ARP test not in this PR if possible).

atenart commented 1 year ago

Looks like your comment gave me some motivation to complete it so we at least have something running for the skb module (#226) :)

(Still, I'd like to add the ARP test not in this PR if possible).

I now have a local patch adding a match on an ARP req/rep in the skb runtime tests. I'll post it once both MRs will be merged.