search

retis-org / retis

Tracing packets in the Linux networking stack & friends
https://retis.readthedocs.io/en/stable/
100 stars 14 forks source link

Cli: Add version #75

Closed vlrpl closed 1 year ago

vlrpl commented 1 year ago

this small series includes the new -V option which shows the version in Cargo.tml and also adds the completion script for bash

edit: dropped the bash script. As discussed during the mtg we'll look into Clap's facilities first.

amorenoz commented 1 year ago

As discussed in the meeting, might be worth looking at https://docs.rs/clap_complete/4.1.1/clap_complete/index.html

atenart commented 1 year ago

Did you evaluate https://docs.rs/clap_complete/4.1.1/clap_complete/ instead of using a custom script? That crate seems quite used, would automate the process and make it easier to maintain, if it can be used.

Edit: sorry, I just read the previous comment, it seems this is already being considered.

vlrpl commented 1 year ago

superseded [1] by #87.

[1] https://github.com/retis-org/retis/pull/87#issuecomment-1584436884