search

retoo / ruby_gettext_extractor

Alternative gettext parser for ruby files
MIT License
4 stars 2 forks source link

Re-release as a gem #4

Closed bkabrda closed 13 years ago

bkabrda commented 13 years ago

Hi, I'm currently packaging gettext_i18n_rails for Fedora project and I found out, that it bundles your ruby_gettext_extractor. Since Fedora has a strict non-bundling policy, could you please make an up-to-date gem of ruby_gettext_extractor, so that I can package it before packaging gettext_i18n_rails (to use it as an external library)?

Thank you very much, Bohuslav Kabrda.

retoo commented 13 years ago

Hi Bohuslav

Michael didnt just bundle my gem, he had to change parts of it to integrate it. I will contact him and discuss the option to dissolve my standalone gem and move all the development to his gem.

Please bug me again should you hear nothing from me.

Cheers Reto

bkabrda commented 13 years ago

Hi, thanks for the quick response! I didn't run diff, but the only difference seems to be that Michael has removed the last line. Anyway, it would be great if you would discuss it with him, as you said.

With regards, Bohuslav.

grosser commented 13 years ago

Id rather not have gettext_i18n_rails bundled in fedora, as far as I can see it the only people who would use gettext_i18n_rails are people with rails apps, and if they use fedora-bundles gems they are 1: crazy 2: just waiting for trouble 3: may open strange issues on already resolved stuff. So no thanks :)

(If you got troubles with any non-rails related gem, Ill gladly help.)

bkabrda commented 13 years ago

Well, the only thing we do is that we basically take the gem and repackage it to rpm. All files are installed in the same locations and the content is not changed, so I don't see why something would not work. BTW, its the people with rails apps who asked us to repackage many of the rails-related gems into rpm.

voxik commented 13 years ago

Hi guys,

If I read this discussion correctly, Reto used the word "dissolve" which I read that he would consider to drop this standalone library in favor of the one bundled in gettext_i18n_rails. Is that right? If the gettext_i18n_rails one becomes officially upstream and this one is dropped, then I see no other problems.

Vit

bkabrda commented 13 years ago

Yes, that is exactly the case, but until ruby_gettext_extractor dissolves, it is not good to bundle it. Anyway, because of the changes made by grosser, I don't think it is a big problem for packaging, since the changes made it different (and thus not bundled library :)).

Bohuslav.

grosser commented 13 years ago

I can namespace it, so there is no collission... (or just rename it and no-one will ever know :D )

retoo commented 13 years ago

I removed the gemspec and added a note to the readme that michaels bundled version is the offical upstream version. This gem was never published to gemcutter/rubygems.

bkabrda commented 13 years ago

Great, thanks guys.