search

retorquere / zotero-better-bibtex

Make Zotero effective for us LaTeX holdouts
https://retorque.re/zotero-better-bibtex/
MIT License
5.2k stars 285 forks source link

All export fails with "too much recursion" #106

Closed andersjohansson closed 10 years ago

andersjohansson commented 10 years ago

Hi, zotero-better-bibtex seems to be causing a rather severe problem in my configuration (deactivating it seems to solve the problem).

No matter what translator (bib* or not) or collection I choose, export always stalls with the error message:

too much recursion zotero / xpcom / translation / translate_firefox.js:483

The stalling line (I believe): https://github.com/zotero/zotero/blob/4.0/chrome/content/zotero/xpcom/translation/translate_firefox.js#L483

I guess this will be hard to debug if it doesn't happen for anyone else. I'll try to look into it more when I have time. Here's my configuration:

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 Plugins:

Adblock Plus 2.6.4 true {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d} AutoPager 0.8.0.10 true autopager@mozilla.org Copy All Links 1.3 true {e6a9a96e-4a08-4719-b9bd-0e91c35aaabc} Disable Anti-Adblock 3.1 true {d49a148e-817e-4025-bee3-5d541376de3b} DOI Protocol 1.0 true doiprotocol@chemieunser.wordpress.com FireGestures 1.8.7 true firegestures@xuldev.org Flat Bookmarks 1.11 true flatbm@xuldev.org Greasemonkey 2.1 true {e4a8a97b-f2ed-450b-b12d-ee082ba24781} Item History for Zotero 1.0.65 true zotero-item-history@mystery-lab.com KeeFox 1.4.2 true keefox@chris.tomlinson keyconfig 20110522 true keyconfig@dorando Multifox 2.2.0 true multifox@hultmann Omnibar 0.7.25.20140626 true omnibar@ajitk.com Paper Machines 0.4.9 true papermachines@chrisjr.org Recoll Indexer 1.2.3 true {359f0058-a6ca-443e-8dd8-09868141bebc} RightBar 0.5 true rightbar@realmtech.net SmoothWheel (AMO) 0.45.8.20130519.3 true {5F590AA2-1221-4113-A6F4-A4BB62414FAC} Stylish 1.4.3 true {46551EC9-40F0-4e47-8E18-8E5CF550CFB8} Ubuntu Firefox Modifications 2.9 true ubufox@ubuntu.com Zotero 4.0.21.5 true zotero@chnm.gmu.edu Zotero Better Bib(La)Tex 0.6.42 true better-bibtex@iris-advies.com ZotFile 3.1 true zotfile@columbia.edu Zutilo Utility for Zotero 1.2.10 true zutilo@www.wesailatdawn.com

retorquere commented 10 years ago

Can you try with only Zotero and BBT active to see whether the problem still exists? Also, can you get me a library export using Zotero testCase?

retorquere commented 10 years ago

Sorry, didn't read that in full. Still, can you try with only BBT + Zotero active?

retorquere commented 10 years ago

Does the error message come with a stacktrace BTW?

andersjohansson commented 10 years ago

Ok, I've tried with only Zotero and BBT and that worked (silly of me to not try that before). It's probably some interaction with some other plugin then. I'll look into it more and try to find the culprit later.

Cheers, Anders

Den 2014-08-29 10:50, AllThatIsTheCase skrev:

Does the error message come with a stacktrace BTW?

— Reply to this email directly or view it on GitHub https://github.com/ZotPlus/zotero-better-bibtex/issues/106#issuecomment-53851864.

retorquere commented 10 years ago

I'm also trying to narrow it down and will add it to my regression tests once you or I find the culprit.

andersjohansson commented 10 years ago

Ok. The offending plugin seems to be Recoll Indexer (http://sourceforge.net/projects/recollfirefox/). Exporting works with only Zotero activated and either of BBT and Recoll Indexer but not both.

Is there any good way to trace the problem further? Seems pretty strange.

andersjohansson commented 10 years ago

BTW, this has worked without problem earlier. It possibly stopped working with some Firefox or BBT update during the last month (when I haven't exported anything).

retorquere commented 10 years ago

Where did you find Recoll Indexer 1.2.3?

retorquere commented 10 years ago

And Ubuntu Firefox Modifications?

andersjohansson commented 10 years ago

Did you miss my last messages? Recoll Indexer seems to be the problem (http://sourceforge.net/projects/recollfirefox/). (Ubuntu Firefox Modifications is installed with this package in Ubuntu: http://packages.ubuntu.com/search?keywords=xul-ext-ubufox)

Den 2014-08-29 13:45, AllThatIsTheCase skrev:

And Ubuntu Firefox Modifications?

— Reply to this email directly or view it on GitHub https://github.com/ZotPlus/zotero-better-bibtex/issues/106#issuecomment-53865713.

retorquere commented 10 years ago

BBT has changed substantially since the version of a month ago, but knowing which plugin triggers it helps enormously. It would also help if I could get a Zotero TestCase export of your full library. You can upload it to http://dbinbox.com/allthatisthecase -- please give it a descriptive name.

retorquere commented 10 years ago

Yes, I had missed the previous messages. I'm up to date now.

retorquere commented 10 years ago

I've got tests that reproduce the error! I'm on it.

retorquere commented 10 years ago

0.6.43 fixes the issue. I've added a message on the recoll indexer forums because I do think that how RI patches Function could be done better; I can't open a ticket there currently. Thanks for reporting this issue, and the analysis, it pointed to an oversight in BBT that was going to break things at some point anyhow.

andersjohansson commented 10 years ago

Great, it works! Thanks for your persistent work on BBT!

retorquere commented 10 years ago

No problem whatsoever. Hold on, are you this Anders Johansson? Is should be thanking you -- the initial BibLaTeX support got in because of your work!

retorquere commented 9 years ago

Recoll Firefox is going to be a problem. The workarounds I need to do to work around the breakage it causes is causing BBT to fail the soon-to-be-mandatory firefox extension review process, and the author does not respond to his message board.

andersjohansson commented 9 years ago

Too bad! And yes, I am that Anders Johansson. I'm mostly using BBT now though, and not the biblatex-translator I made (adapted from bibtex) which since (mostly) was included officially.

retorquere commented 9 years ago

I've posted a fix on the Recoll site but the author seems inactive. It's an incredibly simple fix, but I really don't want to pick up maintenance for an extension I don't use myself. As of the next version, BBT will complain and disable itself when it finds the current Roll Firefox version. I need to make progress towards compliance for the &^#^@$( mandatory signing Mozilla has introduced, and Recoll was making it impossible.

andersjohansson commented 8 years ago

For anyone seeing this, it seems to be fixed on the side of recoll-indexer now (at least until multi-process Firefox). The new version is available here: https://addons.mozilla.org/en-US/firefox/addon/recoll-indexer-1/

retorquere commented 8 years ago

Multi-process FF is going to break everything (the FF crew seem hell-bent on alienating their extension authors of late), but BBT ought to just accept the new version.

andersjohansson commented 8 years ago

Yes, no errors at all!