retorquere / zotero-better-bibtex

Make Zotero effective for us LaTeX holdouts
https://retorque.re/zotero-better-bibtex/
MIT License
5.28k stars 284 forks source link

Single-part patent holder names are always {brace-protected} #1414

Closed nils-werner closed 4 years ago

nils-werner commented 4 years ago

Report ID: ZF9DFM5I-euc

Exporter used: Better BibLaTex

Expected behavior:

If brace-protection is disabled, a patent should be exported as

@patent{key,
  title = {Name Of The Patent},
  holder = {Name Of The Patent Holder},
  [...]
}

Actual behavior:

Iinstead it is exported as

@patent{key,
  title = {Name Of The Patent},
  holder = {{Name Of The Patent Holder}},
  [...]
}
retorquere commented 4 years ago

That was ambiguous in the BBT docs, sorry; I've clarified this now.

The brace-protection is actually case-protection (by way of braces), and only applies to title fields, not creator fields. The braces in the creator fields serve a different purpose: names in bib(la)tex can be entered in a number of ways:

  1. John Paul Jones
  2. Jones, John Paul
  3. {John Paul Jones}

Between these, 1. and 2. mean the same, the third does not; 3 is a single-part name consisting of John Paul Jones, where the other two are two-part names consisting of a given name and a surname.

Normally I'd say "and you have a single-part creator name", but the logs you submitted only have two-part names. Can you paste in the actual faulty output you get? Name Of The Patent is not in the logs you sent.

retorquere commented 4 years ago

For me, the item in ZF9DFM5I-euc exports to

@patent{WernerTimedomainaliasing2018,
  title = {Time Domain Aliasing Reduction for Non-Uniform Filterbanks Which Use Spectral Analysis Followed by Partial Synthesis},
  author = {Werner, Nils and Edler, Bernd},
  date = {2018-02-01},
  holder = {{Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V., Friedrich-Alexander-Universitaet Erlangen-Nuernberg}},
  keywords = {audio signal,block,mypublication,samples,set,subband},
  langid = {english},
  number = {3276620A1},
  type = {patenteu}
}

which does not exhibit the behavior you describe.

retorquere commented 4 years ago

I really can't do anything without further feedback.

nils-werner commented 4 years ago

I see double braces in the BibTeX code you posted:

holder = {{Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V., Friedrich-Alexander-Universitaet Erlangen-Nuernberg}},

They are superfluous, no?

retorquere commented 4 years ago

Ah that. No, that's not superfluous; according to the biblatex manual, page 20, holder is a name-list. Since Zotero doesn't have actual creator fields for the assignee but just an plain text field, I must treat it as a single-part name, and single-part names must be braced as per the explanation above. Without those braces, it would mean the same as

Friedrich-Alexander-Universitaet Erlangen-Nuernberg Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V.

and maybe you even want that, but I can't deduce that from the input.

nils-werner commented 4 years ago

Ah, I missed that. Thanks!

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.