retorquere / zotero-better-bibtex

Make Zotero effective for us LaTeX holdouts
https://retorque.re/zotero-better-bibtex/
MIT License
5.28k stars 284 forks source link

Citation key does not appear after install #2604

Closed ms609 closed 1 year ago

ms609 commented 1 year ago

Hi,

I love the new integration of the Citation Key field – much more convenient than the previous implementation!

One issue however is that when I am editing other fields in a citation, pressing Tab sends the cursor to the Citation Key field. Thus it is no longer possible to navigate between fields using the keyboard.

Debug log ID: L99SBW8H-euc

Thanks for your work on this invaluable plugin!

ms609 commented 1 year ago

Addendum: I just installed Zotero 7 and the devel build of Better Bibtex and the issue persists.

retorquere commented 1 year ago

Reproducible. I have a question about this outstanding with the Zotero team.

retorquere commented 1 year ago

6.7.100 is out which should fix the problem.

ms609 commented 1 year ago

Thanks: I installed v6.7.101 and restarted Zotero.

Tabbing now works as expected among regular citation fields.

But...

Debug log ID: UB5I86DD-euc

retorquere commented 1 year ago

Thanks: I installed v6.7.101 and restarted Zotero.

Tabbing now works as expected among regular citation fields.

But...

When I launch Zotero the Citation Key field is not visible

And this is reproducible for you? A build will drop here in 10 minutes that adds more logging, if you can reproduce, please send a log right after it has happened.

When I disable and re-enable the BB addon, the Citation Key field appears, but is disabled. The text is greyed out, and I can highlight the text but cannot place the cursor in the box or edit the contents.

I've reverted to the previous behavior, I've talked to the Zotero crew, and plugin-added editable fields are not feasible right now. Zotero 7 will get a supported way to do that, but for Zotero 6, an editable citekey field is not possible.

github-actions[bot] commented 1 year ago

:robot: this is your friendly neighborhood build bot announcing test build 6.7.103.2604.4834 ("logging")

Install in Zotero by downloading test build 6.7.103.2604.4834, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

ms609 commented 1 year ago

Yes, reproducible. On 6.7.103:

retorquere commented 1 year ago
* Log immediately after launching Zotero and selecting a citation: `WLNCUKVE-euc`

  * Citation Key field not displayed

I haven't been able to reproduce it. A new build will drop here soon with a potential fix, and more logging. If it's not fixed, please submit a new log.

* Log after toggling Better Bibtex off then on again: `3T9XUVM8-euc`

  * Citation Key field now visible (not editable)

No need to report this. The citation key is going to have to be read-only for Zotero 6. Having it editable messed with the other item fields in the item pane. Zotero 7 will soon add a way that I can have it editable there.

github-actions[bot] commented 1 year ago

:robot: this is your friendly neighborhood build bot announcing test build 6.7.103.2604.4835 ("more logging for #2604")

Install in Zotero by downloading test build 6.7.103.2604.4835, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

ms609 commented 1 year ago

The issue persists: 3AS5C2UX-euc

github-actions[bot] commented 1 year ago

:robot: this is your friendly neighborhood build bot announcing test build 6.7.103.2604.4836 ("always install display code")

Install in Zotero by downloading test build 6.7.103.2604.4836, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

ms609 commented 1 year ago

The issue persists: V4FASI99-euc

And in fact the Citation Key field does not reappear after re-enabling BB: AK46UT84-euc

retorquere commented 1 year ago

You have switched to Zotero 7, L99SBW8H-euc is from Zotero 6, so that's what I thought we were diagnosing. Zotero 7 support is tracked in #2522. Currently it is not possible to display the citation key in Zotero 7, the Zotero team is working to make it possible (see top of #2522).

github-actions[bot] commented 1 year ago

:robot: this is your friendly neighborhood build bot announcing test build 6.7.103.2604.4837 ("more logging")

Install in Zotero by downloading test build 6.7.103.2604.4837, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

ms609 commented 1 year ago

Sorry for the confusion – since I installed Zotero 7 I've been using that version exclusively.

In that case v6.7.103.2604.4836 is behaving as we expect: Citation Key field is never visible, but the key can be edited (I now see) via the context menu. That configuration works fine for now, and I'll look forwards to enjoying the new behaviour once you are able to take advantage of the forthcoming Zotero 7 API.

Thanks for your help diagnosing this issue, and thanks again for the excellent plugin!

github-actions[bot] commented 1 year ago

Thanks for the feedback; there's no way you could have known, but @retorquere prefers to keep bugreports/enhancements open as a reminder to merge the changes into a new release.

retorquere commented 1 year ago

L99SBW8H-euc was from Zotero 6 though.

jrennstich commented 1 year ago

Debug Log from 4845: DCZTD3XH-euc/6.7.103.2522.4845-7

retorquere commented 1 year ago

Citation key cannot be displayed in Zotero 7 until the Zotero team makes the new API available.

jrennstich commented 1 year ago

Ok. Just wanted to send a debug log for information purposes, since the message read "debug log version" and I figured, you were interested in debugs :-)

retorquere commented 1 year ago

No worries. I expect the item field API somewhere this or next week.