retorquere / zotero-better-bibtex

Make Zotero effective for us LaTeX holdouts
https://retorque.re/zotero-better-bibtex/
MIT License
5.39k stars 290 forks source link

using zotero://select to select multiple citationkeys. #2993

Closed jshahin closed 1 month ago

jshahin commented 2 months ago

Debug log ID

GX62HJIN-euc/6.7.231-7

What happened?

I would like to be able to select more than one citationkey using the zotero://select function. this currently does not work in BBT.

github-actions[bot] commented 2 months ago

:robot: this is your friendly neighborhood build bot announcing test build 6.7.234.7043 ("Merge branch 'gh-2992'")

This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 6.7.234.7043, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

retorquere commented 2 months ago

Please try with this build (which will fail) and then send a new log.

retorquere commented 1 month ago

still interested?

jshahin commented 1 month ago

Yes, sorry, it’s a crazy fortnight; teaching both in NL and Belgium, and conferences. Will try tomorrow if OK with you, sorry for the delay!!On 26 Sep 2024, at 08:46, Emiliano Heyns @.***> wrote: still interested?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

retorquere commented 1 month ago

No problem, trust me, I know how that is.

jshahin commented 1 month ago

Hi Emiliano

As promised, I have run, and yes, it failed :). On entering:

@.***

Into my browser, Zotero ‘beachballed' for a very long time, and then selected everything. One other weird thing: it opened all the triangles (so makes all attachments visible in the list view in my library (see screenshot).

J2TJ8TCZ-euc/6.7.234.7043-7

All the best, -Jamal

On 26 Sep 2024, at 08:55, Emiliano Heyns @.***> wrote:

No problem, trust me, I know how that is.

— Reply to this email directly, view it on GitHub https://github.com/retorquere/zotero-better-bibtex/issues/2993#issuecomment-2376083574, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5PUHR64QJKMSG5SZPG3N3ZYOVUXAVCNFSM6AAAAABOQUO4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZWGA4DGNJXGQ. You are receiving this because you authored the thread.

retorquere commented 1 month ago

sorry, didn't read beneath the cut.

jshahin commented 1 month ago

Do I need to do anything extra then?

On 27 Sep 2024, at 01:41, Emiliano Heyns @.***> wrote:

sorry, didn't read beneath the cut.

— Reply to this email directly, view it on GitHub https://github.com/retorquere/zotero-better-bibtex/issues/2993#issuecomment-2378126131, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5PUHRYLR7DXQLHCGM2AG3ZYSLT5AVCNFSM6AAAAABOQUO4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYGEZDMMJTGE. You are receiving this because you authored the thread.

github-actions[bot] commented 1 month ago

:robot: this is your friendly neighborhood build bot announcing test build 6.7.236.7088 ("more logging")

This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 6.7.236.7088, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

retorquere commented 1 month ago

new log please

jshahin commented 1 month ago

Done!

IPN8HJGH-euc/6.7.236.7088-7

All best, -Jamal

On 27 Sep 2024, at 09:46, Emiliano Heyns @.***> wrote:

new log please

— Reply to this email directly, view it on GitHub https://github.com/retorquere/zotero-better-bibtex/issues/2993#issuecomment-2378628733, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5PUHQU5ZI45CVI36KZ4UDZYUEMNAVCNFSM6AAAAABOQUO4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYGYZDQNZTGM. You are receiving this because you authored the thread.

github-actions[bot] commented 1 month ago

:robot: this is your friendly neighborhood build bot announcing test build 6.7.236.7089 ("getResultsFromParams")

This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 6.7.236.7089, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

jshahin commented 1 month ago

It worked?!

RV852YNM-euc/6.7.236.7089-7

Wow!!

Best wishes,
-Jamal

On 27 Sep 2024, at 12:59, github-actions[bot] @.***> wrote:

🤖 this is your friendly neighborhood build bot announcing test build 6.7.236.7089 https://github.com/retorquere/zotero-better-bibtex/releases/download/builds/zotero-better-bibtex-6.7.236.7089.xpi ("getResultsFromParams")

This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 6.7.236.7089 https://github.com/retorquere/zotero-better-bibtex/releases/download/builds/zotero-better-bibtex-6.7.236.7089.xpi, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

— Reply to this email directly, view it on GitHub https://github.com/retorquere/zotero-better-bibtex/issues/2993#issuecomment-2379011292, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5PUHVHNAVODBQ5PVL5MBLZYU3BBAVCNFSM6AAAAABOQUO4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZGAYTCMRZGI. You are receiving this because you authored the thread.

retorquere commented 1 month ago

Also for multiple then?

jshahin commented 1 month ago

How do I write out multiple? Separate with an &?Sorry, amateur hour here :-)On 27 Sep 2024, at 13:48, Emiliano Heyns @.***> wrote: Also for multiple then?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

retorquere commented 1 month ago

Just as you would with multiple item keys.

jshahin commented 1 month ago

so, after referring to: https://forums.zotero.org/discussion/75794/feature-request-allow-multiple-item-selection-with-zotero-select, I tried zotero://select/library/items?citationKey=gerring2008,gerring2009 and that did nothing.

Neither did: zotero://select/library/items?citationKey=@gerring2008,@gerring2009.

zotero://select/library/items/@gerring2008,@gerring2009 selected the entire library.

9DES2FYW-euc/6.7.238-7

github-actions[bot] commented 1 month ago

:robot: this is your friendly neighborhood build bot announcing test build 6.7.238.7096 ("Merge branch 'master' into gh-2993")

This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 6.7.238.7096, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

retorquere commented 1 month ago

Please retry on build 7096

jshahin commented 1 month ago

Afraid the same experience as last time:

WASVVBWS-euc/6.7.238.7096-7

Best wishes,
-J

On 29 Sep 2024, at 00:48, Emiliano Heyns @.***> wrote:

Please retry on build 7096

— Reply to this email directly, view it on GitHub https://github.com/retorquere/zotero-better-bibtex/issues/2993#issuecomment-2381015404, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5PUHVZ2HAPO4TED7WEX6TZY4W2BAVCNFSM6AAAAABOQUO4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGAYTKNBQGQ. You are receiving this because you authored the thread.

retorquere commented 1 month ago

But does that actually work to select these items if you select them by their item keys instead of their citation keys?

retorquere commented 1 month ago

You can get the item keys by selecting some items and then going into Tools - Developer - Run Javascript and entering

ZoteroPane.getSelectedItems().map(item => item.key)

and press Run

jshahin commented 1 month ago

Thanks, I was just trying to find out how to do that. Indeed, that (see example below) works perfectly!

zotero://select/library/items?itemKey=ZPAGHTHD,SF46N4F2,IL6VAQU5,SK6QTBYT

Best wishes,
-Jamal

On 29 Sep 2024, at 01:55, Emiliano Heyns @.***> wrote:

You can get the item keys by selecting some items and then going into Tools - Developer - Run Javascript and entering

ZoteroPane.getSelectedItems().map(item => item.key) and press Run

— Reply to this email directly, view it on GitHub https://github.com/retorquere/zotero-better-bibtex/issues/2993#issuecomment-2381027527, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5PUHQ6GYNJ3H66IGXYKB3ZY46YZAVCNFSM6AAAAABOQUO4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGAZDONJSG4. You are receiving this because you authored the thread.

retorquere commented 1 month ago

Can you send me a new log after you did that?

jshahin commented 1 month ago

Sure, here it is:

QUXZUENW-euc/6.7.238.7096-7

Carried out on: zotero://select/library/items?itemKey=P4FBPSLU,PNAR8RAH,9KK62BU8,IL6VAQU5,V5AK2CU3

On 29 Sep 2024, at 02:08, Emiliano Heyns @.***> wrote:

Can you send me a new log after you did that?

— Reply to this email directly, view it on GitHub https://github.com/retorquere/zotero-better-bibtex/issues/2993#issuecomment-2381030510, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5PUHWZGVPARBZZAEYLQWLZY5AGZAVCNFSM6AAAAABOQUO4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGAZTANJRGA. You are receiving this because you authored the thread.

github-actions[bot] commented 1 month ago

:robot: this is your friendly neighborhood build bot announcing test build 6.7.238.7100 ("key translate")

This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 6.7.238.7100, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

jshahin commented 1 month ago

Hi! No change.

I carried out zotero://select on multiple itemkeys and that worked.

I carried out @.**@*.**@*.**@*.**@*.*** and that didn’t seem to react, as well as some other variants (citationkey all in lower case, omitting the “/library” part).

Debug log: 3CJYSLZZ-euc/6.7.238.7100-7

On 29 Sep 2024, at 03:48, github-actions[bot] @.***> wrote:

🤖 this is your friendly neighborhood build bot announcing test build 6.7.238.7100 https://github.com/retorquere/zotero-better-bibtex/releases/download/builds/zotero-better-bibtex-6.7.238.7100.xpi ("key translate")

This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 6.7.238.7100 https://github.com/retorquere/zotero-better-bibtex/releases/download/builds/zotero-better-bibtex-6.7.238.7100.xpi, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

— Reply to this email directly, view it on GitHub https://github.com/retorquere/zotero-better-bibtex/issues/2993#issuecomment-2381057746, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5PUHUARB3OF7LD76QIX33ZY5L6BAVCNFSM6AAAAABOQUO4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGA2TONZUGY. You are receiving this because you authored the thread.

github-actions[bot] commented 1 month ago

:robot: this is your friendly neighborhood build bot announcing test build 6.7.238.7103 ("more logging")

This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 6.7.238.7103, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

jshahin commented 1 month ago

No change, sorry..

Tried zotero://select/library/items?itemKey=P4FBPSLU,PNAR8RAH,9KK62BU8,IL6VAQU5,V5AK2CU3 and that worked.

Tried: @.**@*.**@*.**@*.**@*.*** and that doesn’t work

Tried: @.*** and that doesn’t work either

But good old @.*** does!

2EEJ62KS-euc/6.7.238.7103-7

On 29 Sep 2024, at 19:35, github-actions[bot] @.***> wrote:

🤖 this is your friendly neighborhood build bot announcing test build 6.7.238.7103 https://github.com/retorquere/zotero-better-bibtex/releases/download/builds/zotero-better-bibtex-6.7.238.7103.xpi ("more logging")

This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 6.7.238.7103 https://github.com/retorquere/zotero-better-bibtex/releases/download/builds/zotero-better-bibtex-6.7.238.7103.xpi, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

— Reply to this email directly, view it on GitHub https://github.com/retorquere/zotero-better-bibtex/issues/2993#issuecomment-2381437547, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5PUHUSLFP3V7QRO625H23ZZA26JAVCNFSM6AAAAABOQUO4KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGQZTONJUG4. You are receiving this because you authored the thread.

retorquere commented 1 month ago

Most of the text posted is unreadable, sorry. Please use the web interface. The mail-response interface of github has a lot of issues.

I can see the first form in your logs, the other doesn't trigger my code. I'll have to dive into zotero to see what sanity checks it does to weed them out.

jshahin commented 1 month ago

Reposting:

No change, sorry..

Tried zotero://select/library/items?itemKey=P4FBPSLU,PNAR8RAH,9KK62BU8,IL6VAQU5,V5AK2CU3 and that worked.

Tried: zotero://select/library/items?citationkey=@gerring2008,@gerring2008a,@gerring2009,@gersbach2005e,@gervais2013 and that doesn’t work

Tried: zotero://select/library/items?citationkey=@gerring2008 and that doesn’t work either

But good old zotero://select/library/items/@gerring2008 does!

retorquere commented 1 month ago

Just as you would with multiple item keys.

it's

zotero://select/library/items?itemKey=@gerring2008,@gerring2008a,@gerring2009,@gersbach2005e,@gervais2013

not

zotero://select/library/items?citationkey=@gerring2008,@gerring2008a,@gerring2009,@gersbach2005e,@gervais2013

Zotero does not support citationkey= so my code never gets called.

jshahin commented 1 month ago

that works! (sorry, brief)