search

retorquere / zotero-better-bibtex

Make Zotero effective for us LaTeX holdouts
https://retorque.re/zotero-better-bibtex/
MIT License
5.18k stars 283 forks source link

bibtex export of phdthesis does not case-protect "type" #435

Closed murmlgrmpf closed 6 years ago

murmlgrmpf commented 8 years ago

Hi,

We have recognized that the export of phdthesis wit better-bibtex does not put the type into curli brackets.

@phdthesis{Zellh13,
  type = {PhD Thesis},

Whereas it should be 

@phdthesis{Zellh13,
  type = {{PhD} {Thesis}},

This has the negative impact that in the bibliography PhD will show up as Phd. The standard bibtex export does feature the brackets.

Best, Thomas

retorquere commented 8 years ago

Can you right-click that reference for me and select "send better bibtex error"? That will give me a test case.

murmlgrmpf commented 8 years ago

Sorry, I was skiing this weekend. I will send you the error as soon as I am back in office on Monday.

murmlgrmpf commented 8 years ago

329RQKFE Is the error key.

retorquere commented 8 years ago

Tests are running, this is what is currently output. The reason for the double braces can be found in this discussion should you wonder; the TL;DR is that BibTeX has more exceptions than it has rules, and double-brace seems to do the job consistently where single-brace does not. I also group adjacent words that would normally be brace-protected into a single braced-protected group to minimise clutter.

retorquere commented 8 years ago

Tests green, good to go if you can confirm this is the output you want.

murmlgrmpf commented 8 years ago

Yes, I can confirm, this is the output that fixes my Issue. Thank you very much!

retorquere commented 8 years ago

Super. I'm traveling now, but when I get access to a computer I'll cut a release

blip-bloop commented 6 years ago

:robot: this is your friendly neighborhood build bot announcing test build 5450 ("test for #435").

blip-bloop commented 6 years ago

:robot: this is your friendly neighborhood build bot announcing test build 5451 ("test for #435").

lock[bot] commented 6 years ago

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.