Git auto push does not actually push changes to the repository on Windows

[wittenator]

Bug classification

I tried to setup a pipeline for pdf creation from latex files in gitlab. Part of that endeavour is the git push support from betterbibtex. I set it up, added the git config in the repo and exported the collection with the right flag. Whenever I add a new item to the collection, the .bib file gets updated. Sadly the actual push to the remote git repo does not happen. I tried both saving the ssh key and the credentials for gitlab, because I suspected that that may be a reason for a silent failure. But it didn't help. Did anyone encounter similar problems with this feature?

Exporting references

• FYA494LP (BibTeX)

Non-export problems with BBT

• EX8RDSJ5

[retorquere]

All at once is not possible, since the sequence must be

1. git pull (to make sure we don't get merge conflicts in the last step, I am not going to create an UI to deal with merge conflicts)
2. create bib
3. add/commit/push

so there's a need for at least two calls. But try 3395.

[blip-bloop]

:robot: this is your friendly neighborhood build bot announcing test build 5.1.46.3407 ("5.1.46")

Install in Zotero by downloading test build 5.1.46.3407, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

[wernersa]

Auto-export doesn't work in 3395

(1)(+0000004): {better-bibtex! +4} could not pull in B:\directory: <Error: Cannot modify properties of a WrappedNative# exec@chrome://zotero-better-bibtex/content/common.js:55126:9 pull@chrome://zotero-better-bibtex/content/common.js:55098:19 run@chrome://zotero-better-bibtex/content/common.js:55216:19 run@chrome://zotero-better-bibtex/content/common.js:55329:9 run@chrome://zotero-better-bibtex/content/BetterBibTeX.Preferences.js:158:9 oncommand@chrome://zotero/content/preferences/preferences.xul#better-bibtex:1:1 gViewController.commands.cmd_showItemPreferences.doCommand@chrome://mozapps/content/extensions/extensions.js:1193:9 gViewController.doCommand@chrome://mozapps/content/extensions/extensions.js:1530:5 showPreferences@chrome://mozapps/content/extensions/extensions.xml:1555:11 oncommand@chrome://mozapps/content/extensions/extensions.xul:1:1 >

There was no other related errors

[blip-bloop]

:robot: this is your friendly neighborhood build bot announcing test build 5.1.46.3416 ("cannot modify environment dict")

Install in Zotero by downloading test build 5.1.46.3416, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

[wernersa]

Tried 3416, and it broke the pathsearch: (3)(+0000014): {better-bibtex +14} git.init: git not found: <Error: Executable not found: git# SubprocessWin.pathSearch<@resource://gre/modules/subprocess/subprocess_win.jsm:162:17 TaskImpl_run@resource://gre/modules/Task.jsm:319:42 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:932:23 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7 this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11 >

[retorquere]

There must be something just before it if you have extended logging on with pathSearch: looking for

[retorquere]

(generally in these test build I add logging to diagnose the error so I'd prefer getting a log)

[wernersa]

Didn't know about the good reporting options! Sorry for the inconvenient reporting :) Report-ID: G4MCXCGR-euc

[blip-bloop]

:robot: this is your friendly neighborhood build bot announcing test build 5.1.46.3420 ("firefox is pretty finnicky")

Install in Zotero by downloading test build 5.1.46.3420, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

[retorquere]

No worries -- I thought you had used it before but that was the OP. Can you try 3420 with both PATH and PATHEXT in capitals? Firefox seems very finnicky about env vars, and the only other option would be to re-implement pathSearch myself. I will if I must but I'd rather not.

[wernersa]

Still doesnt work :/

My environment: https://transfer.sh/141dPo/SystemPropertiesAdvanced_2019-01-29_13-36-30.png

(3)(+0000000): {better-bibtex +0} pathSearch: looking for git

(1)(+0000014): {better-bibtex! +14} pathSearch: PATH not set

(3)(+0000000): {better-bibtex +0} git.init: git not found

Report-ID: 93X4DA5X-euc

Submitted with Debug ID: D1453173287

[retorquere]

And if you type set in a command window?

[wernersa]

Pretty sure that would be restricted in scope to the process of that specific terminal window.

Didn't do any change

Den tir. 29. jan. 2019 kl. 15:35 skrev Emiliano Heyns < notifications@github.com>:

And if you type set in a command window?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/retorquere/zotero-better-bibtex/issues/972#issuecomment-458562120, or mute the thread https://github.com/notifications/unsubscribe-auth/AMtrnL9cODCyjcGJ4f_MRrQ1hzkFZOR-ks5vIFwvgaJpZM4UC_fp .

[retorquere]

Why would that be restricted in scope? AFAIK windows has two sets of environment variables -- system-wide (are set for everyone) and user-specific (only apply to the logged in user and override system-wide). I'm not aware of any app-specific level of env vars for windows.

[blip-bloop]

:robot: this is your friendly neighborhood build bot announcing test build 5.1.46.3421 ("reimplement pathSearch")

Install in Zotero by downloading test build 5.1.46.3421, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

[retorquere]

3421 has my own implementation of pathsearch, give that a go.

[wernersa]

Pathsearch works now, although you successfully had pathsearch working in 3388 though. The same problem persists as in 3395:

(1)(+0000038): {better-bibtex! +38} could not pull in B:\overleaf: <Error: Cannot modify properties of a WrappedNative# exec@chrome://zotero-better-bibtex/content/common.js:55246:9 pull@chrome://zotero-better-bibtex/content/common.js:55218:19 run@chrome://zotero-better-bibtex/content/common.js:55334:19 run@chrome://zotero-better-bibtex/content/common.js:55456:9 run@chrome://zotero-better-bibtex/content/BetterBibTeX.Preferences.js:158:9 oncommand@chrome://zotero/content/preferences/preferences.xul:1:1 >

Report-ID: L2R8NVSM-euc

[retorquere]

Ah dammit. Zotero builds on an old Firefox version (52.9.0esr), and that ability to start programs without a shell popping up on Windows wasn't added until Firefox 55. There's nothing I can do about this.

[retorquere]

I'm building 3423 now which should work (and should work with any spelling of the path variable on Windows) but the shells popping up is out of my hands. I can look at whether I can minimize the number of calls, but two is the minimum for the reason I outlined above.

[blip-bloop]

:robot: this is your friendly neighborhood build bot announcing test build 5.1.46.3423 ("Zotero builds on an old FF, this won't work")

Install in Zotero by downloading test build 5.1.46.3423, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

[retorquere]

On windows you might be better off with running sparkleshare until Zotero upgrades to FF55+

[retorquere]

4 is actually the minimum because I can't chain commands into 1 using the api I can use.

[wernersa]

Thanks for trying to work it out! Great job :)

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.