search

retorquere / zotero-folder-import

304 stars 19 forks source link

fix #21 - auto-recognize linked pdfs #30

Closed somelinguist closed 1 year ago

somelinguist commented 1 year ago

It looks like the plugin isn't adding linked items that are PDFs to the array of PDFs that should be auto-recognized. They're only added for non-linked items (see line 174):

https://github.com/retorquere/zotero-folder-import/blob/bfcf55ea7f323d4d4d2b4a724487365fb2550ebd/content/zotero-folder-import.ts#L154-L188

Zotero's dialog for adding attachments also adds linked items to the items to auto-recognize when they are top-level:

https://github.com/zotero/zotero/blob/d866a10a2b56e96631a1563572d3f2918f1f006a/chrome/content/zotero/zoteroPane.js#L4269 until L4321 (especially lines 4314 and 4319).

This changes the plugin's behavior to be more like the behavior of Zotero's attachment dialog.

github-actions[bot] commented 1 year ago

:robot: this is your friendly neighborhood build bot announcing test build 0.0.5.26 ("Merge pull request #30 from somelinguist/master\n\nfix #21 - auto-recognize linked pdfs")

Install in Zotero by downloading test build 0.0.5.26, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

github-actions[bot] commented 1 year ago

:robot: this is your friendly neighborhood build bot announcing test build 0.0.5.27 ("Merge pull request #30 from somelinguist/master\n\nfix #21 - auto-recognize linked pdfs")

Install in Zotero by downloading test build 0.0.5.27, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".