search

retorquere / zotero-storage-scanner

A Zotero plugin to remove the broken & duplicate attachment link of the bibliography
519 stars 19 forks source link

Do not mark Links as #broken_attachements #11

Closed ghost closed 5 years ago

ghost commented 6 years ago

Currently, when I run storage scanner, all the attachements that are actually only links to a website (not a snapshot, thus not "real" attachements) are marked as broken. I would really appreaciate if there was a way to change this in storage scanner, letting it check only for real attachments. I hope I could explain the issue, please let me know if it is unclear what I mean. Thank you very much for providing this extension!

blip-bloop commented 6 years ago

:robot: this is your friendly neighborhood build bot announcing test build 5.0.7.34 ("addTag strips spaces, hastag does not...").

retorquere commented 6 years ago

Can you try .34?

ghost commented 6 years ago

Hi,

I couldnt send you the sqlite file, because it is to large. What to do?

Best, Moritz

Am 02.07.2018 um 10:33 schrieb Moritz Heber moritz@blueberryhill.de:

Hi,

I updated to the latest test built 7.34 and tried again. It works almost perfectly, there is only one case where a link gets erroneously marked as broken. It is this item (Pressemappe_Deutsches_Museum.pdf):

I am wondering if this issue arises, because I am using zotero on two different machines and the file in question is stored on one PC, while I am running storage scanner on the other — so the link gets marked as broken, because the file lives on another machine? Anyway, I attach my sqlite file here, I hope this is helpful. Thank you very much for your work on this extension! Best, Moritz > Am 01.07.2018 um 21:09 schrieb Emiliano Heyns >: > > Can you shut down Zotero, zip up your zotero.sqlite, and attach it here? Can you also give me the title of one of the links that are erroneously tagged as broken? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub , or mute the thread . >
retorquere commented 6 years ago

Zipping it should do it usually, but first see whether .34 is better.

ghost commented 6 years ago

It did zip it, still too large :))

I also checked out the .34 version which works a lot better — there was only only error…

Am 02.07.2018 um 12:40 schrieb Emiliano Heyns notifications@github.com:

Zipping it should do it usually, but first see whether .34 is better.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/retorquere/zotero-storage-scanner/issues/11#issuecomment-401760315, or mute the thread https://github.com/notifications/unsubscribe-auth/AR1RFUOhXFNjr7u4geQ8LnnZvwBhaAi7ks5uCfiTgaJpZM4U-Pq3.

retorquere commented 6 years ago

What error was that?

retorquere commented 6 years ago

How large is that zip?

ghost commented 6 years ago

7,7 MB

Am 02.07.2018 um 16:57 schrieb Emiliano Heyns notifications@github.com:

How large is that zip?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/retorquere/zotero-storage-scanner/issues/11#issuecomment-401833762, or mute the thread https://github.com/notifications/unsubscribe-auth/AR1RFW5Bptam4s0wVNUvT55HeT_39UBdks5uCjTsgaJpZM4U-Pq3.

ghost commented 6 years ago

I updated to the latest test built 7.34 and tried again. It works almost perfectly, there is only one case where a link gets erroneously marked as broken. It is this item (Pressemappe_Deutsches_Museum.pdf):

I am wondering if this issue arises, because I am using zotero on two different machines and the file in question is stored on one PC, while I am running storage scanner on the other — so the link gets marked as broken, because the file lives on another machine?

Am 02.07.2018 um 16:57 schrieb Emiliano Heyns notifications@github.com:

What error was that?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/retorquere/zotero-storage-scanner/issues/11#issuecomment-401833565, or mute the thread https://github.com/notifications/unsubscribe-auth/AR1RFT1u4rZ9Ob_nxAI_zBzgwHNr_2tVks5uCjTKgaJpZM4U-Pq3.

retorquere commented 6 years ago

That would absolutely happen. Tags are synced, but the scanner can only see the local state.

ghost commented 6 years ago

Alright, that explains it. So in other words the issue was fixed with version 34 — thank you again for your help! Best, Moritz

Am 02.07.2018 um 17:22 schrieb Emiliano Heyns notifications@github.com:

That would absolutely happen. Tags are synced, but the scanner can only see the local state.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/retorquere/zotero-storage-scanner/issues/11#issuecomment-401841348, or mute the thread https://github.com/notifications/unsubscribe-auth/AR1RFewD3g2MQU9WMYOY-st1DCcSeLOxks5uCjqtgaJpZM4U-Pq3.

retorquere commented 6 years ago

Super, 5.0.8 has been scheduled for a release. You will be upgraded automatically in a few days (don't know how long Zotero takes between update checks)