search

retorquere / zotero-storage-scanner

A Zotero plugin to remove the broken & duplicate attachment link of the bibliography
530 stars 19 forks source link

#nosource tag #13

Open Verkiel opened 5 years ago

Verkiel commented 5 years ago

Love zotero, love this plugin. I'm just wondering what the criteria are for assigning the #nosource tag? I get quite a few of them whenever I run the storage scanner. The tag is generally - but not exclusively - assigned to parent items without child items, but not to all of those in my collections, and I can't figure out why =)

retorquere commented 5 years ago

The criterion is whether I see an attachment in the DB, but it's possible I'm counting wrong. Are you saying it's sometimes not assigned when you would expect it to be? Or that it is assigned when you don't expect it to be?

JD4x4 commented 5 years ago

I just audited my Library for #nosource, and I'm seeing that the tag is set even though I have a note as the only child item. My suggestion is that it should NOT tag these entries. fwiw.

Untill/if you chjange it, next time I run I may try a library search on #nosource plus Note and see if I can weed out some of these.

Super useful tool regardless! Thanx!!

retorquere commented 5 years ago

Notes aren't counted as attachments currently.

JD4x4 commented 5 years ago

Notes aren't counted as attachments currently.

umm.. thanks, but I already observed that, lol! Just wanted to give you feedback on how you could make it more relevant & useful to a wider audience. Thanks again for coding it in the 1st place, and have a great day!

gsingh93 commented 2 years ago

I'm a little confused about this tag as well, I have multiple entries that have PDF attachments that have the #nosource tag.

retorquere commented 2 years ago

I'd have to get a copy of your zotero DB to know why it's tagging entries with attachments as nosource

markNZed commented 2 years ago

I noticed the #nosource tag was associated with documents that did not have parent items. These items were not able to be automatically resolved to generate parent items. I was assuming that #nosource indicates something like no DOI

retorquere commented 2 years ago

nosource indeed is put on attachments that aren't attached to anything.

markNZed commented 2 years ago

After adding parent items the tag was not removed from the files (which have become attachments). I removed the #nosource tag and running again those items no longer have #nosource.

retorquere commented 2 years ago

Just running it again should have removed the tag.

markNZed commented 2 years ago

I would have expected that too. But it did not seem to do that. It is not obvious to know if the process is running and/or has completed, so maybe I missed something. But I'm pretty sure it did not reset those tags (it did not add the #nosource tag to the new items either, which seems correct)

GittyBruce commented 1 year ago

Running into the same issue as markNzed. A few items with child items (pdfs) retain #nosource tag after re-running the scan multiple times. The only hint I have is that those entries are all entries that were correctly marked as #nosource, and then got merged with duplicate entries that had the child .pdfs.

To reproduces this bug:

  1. Duplicate an entry
  2. Remove child item from one
  3. Run the scanner
  4. Merge the entries
  5. Run the scanner again and it will fail to remove #nosource.