search

retorquere / zotero-sync

https://retorque.re/zotero-sync/
GNU Affero General Public License v3.0
33 stars 3 forks source link

Avoid "undefined" library name for user library #5

Closed cboulanger closed 3 years ago

retorquere commented 3 years ago

The thing is that the user library does not have a fixed name. It is locale dependent. I'd rather signal somehow that this concerns the user library so that it is clear that if a name is to be displayed, it is up to the consumer to think of one.

cboulanger commented 3 years ago

Makes sense. I'll check for undefined in my own code.

retorquere commented 3 years ago

I've added a type to RemoteLibrary

cboulanger commented 3 years ago

Cool. This allows a more robust checking (name could be undefined for many reasons)

retorquere commented 3 years ago

It can't, really. Zotero groups always have a name.

Hmmm... instead of the prefix + type, we could break the two out; both would have type and id, and prefix would just be /${type}/${id}. The type is otherwise implied by the lead of the prefix.