retostauffer / python-colorspace

Python colorspace implementation. Documentation available on https://retostauffer.github.io/python-colorspace/. The latest release is available via the Python Package Index (PyPI) via https://pypi.org/project/colorspace/
Other
69 stars 15 forks source link

setuptools not always included in virtualenv #23

Closed dmreagan closed 1 month ago

dmreagan commented 2 months ago

I'm testing the installation procedures for the review at openjournals/joss-reviews#7120. I tried following the instructions for installing from a git clone.

git clone https://github.com/retostauffer/python-colorspace.git
cd python-colorspace && python setup.py install

It worked just fine from a conda environment, but failed when I tried a virtualenv environment because setuptools was missing. I am on a Ubuntu system. It might be worth adding a line to the documentation that not all virtual environments will include setuptools by default, or else find some way to ensure that setuptools is there.

retostauffer commented 1 month ago

Dear @dmreagan,

Thank you for bringing this issue to our attention. We have made several updates to both our documentation and the Makefile to ensure that setuptools is installed when installing colorspace from source, either on the system or in a virtual environment.

Documentation updates

Makefile updates

We've added setuptools installation steps in the virtual environment setup:

These changes should ensure that setuptools is installed if it’s not already available.

dmreagan commented 1 month ago

Looks good to me. Closing.