Closed retowuest closed 4 years ago
Can we include in this version a warning message at the beginning saying that this is the case whenever somebody tries using their own folds?
Something like this line added to auto_MrP function early:
if (!missing(folds)) warning('Currently the SVM part does not use user-supplied folds. This will be added in the next version.’)
Best, Lucas
On Apr 24, 2020, at 8:36 PM, Reto Wuest notifications@github.com wrote:
Even if the user provides k custom folds to auto_mrp(), svm is, as it currently stands, not evaluated on exactly these folds. The folds provided by the user are merged and svm then creates its own k folds.
We might want to consider changing this so that svm is evaluated on the exact same folds as the other classifiers.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.
Yes, sounds good, I'll implement this.
SVM now uses our folds (removed the warning)
Even if the user provides k custom folds to auto_mrp(), svm is, as it currently stands, not evaluated on exactly these folds. The folds provided by the user are merged and svm then creates its own k folds.
We might want to consider changing this so that svm is evaluated on the exact same folds as the other classifiers.