retrievercommunications / docker-jasperserver

Docker image for the community edition of JasperReports® Server.
https://hub.docker.com/r/retriever/jasperserver/
MIT License
46 stars 50 forks source link

Plugin Web Service Data Source #11

Closed chiavegatto closed 6 years ago

chiavegatto commented 6 years ago

I need add plugin Web Service Data Source, but when coppy files to restart container, new configuration jasper-server in tomcat. I need help :)

grange74 commented 6 years ago

Hi, I assume you are following the instructions "Install in TIBCO JasperReports Server" on https://community.jaspersoft.com/wiki/installing-webservice-datasource? How are you implementing these instructions? by modifying the "entrypoint.sh" or some other way?

Basically from what i see you would need a number of things to add this container image:

Then when the final line in "entrypoint.sh" (catalina.sh run) starts tomcat it should start the jasperserver with the Web Service Datasource plugin available.

Btw, as this would have general applicability, we would welcome a Pull Request for this feature :-).

chiavegatto commented 6 years ago

I done add WebServiceDataSource plugin, but i don't permission submit pull request.

https://github.com/chiavegatto/docker-jasperserver

grange74 commented 6 years ago

Hi @chiavegatto, you shouldn't need to have any specific permissions to submit a PR. I've just tried it with a brand new GitHub account, i forked the repo, did a dummy commit, and then created a PR. What error message are you getting?

grange74 commented 6 years ago

I was looking at your changes on your fork and they look really good. My main comment is that it would be nice to have each of the changes in separate branches (or atleast commits) instead of all together in one commit on master. So i would split probably into 3:

This helps with maintaining a clean history by being able to identify why each change was made.

grange74 commented 6 years ago

PR is now merged in. Thank you @chiavegatto for your contribution!