Closed AJIOB closed 2 years ago
Sorry for the delayed response. Thanks for your contribution. It is much appreciated. I ran a quick test of your branch and it seems to start fine. I will merge PR soon. Just made a couple of very minor comments.
Thanks for merging.
If need, I can add a comment in the new MR or you can add it by yourself.
I'm waiting for new tag (7.5.0)
I've added the comment and tag. Its been a while since i have do it and it seems that now automated builds in Docker hub are a paid feature so i will have to do it manually.
ok, 7.5.0 is now on docker hub (https://hub.docker.com/r/retriever/jasperserver/tags). Not sure why but it was very slow to upload. It took ages.
Thanks again for your contribution.
I will update the readme to reflect the manual process. Free automated builds seems to have been removed in June this year as per https://www.docker.com/blog/changes-to-docker-hub-autobuilds/.
Something to note is that with version 7.5.0 and the new encryption key process, it makes it harder to upgrade versions or recreate the jasperserver container and keep the same database. An improvement we need to make it to define a volume/mount to store the keys so that they saved outside of the container and hence survive the container being destroyed. See this issue for reference: https://github.com/retrievercommunications/docker-jasperserver/issues/38 We'd welcome another contribution if you have time. Thanks.
Building & startup was tested locally with docker compose on postgresql db.
Source archive downloading was also tested from sourceforge.