search

retrixe / decaffeinater

Sometimes games give you overdoses. This one will help you set a timer to limit yourself.
Apache License 2.0
1 stars 0 forks source link

compiling on windows doesn't run "npm install" #3

Closed retrixe closed 7 years ago

retrixe commented 7 years ago

When compiling for windows, electron-builder doesn't install app dependencies in app/ automatically before creating the executable.. workaround would be to create a custom build script which can detect and solve the issue..

retrixe commented 7 years ago

would like to add that this may also be the case on macOS but I have yet to be able to provide macOS compiles because they do not produce on Linux .-.

retrixe commented 7 years ago

This is not the issue on macOS, macOS builds are now automated by travis ci.

retrixe commented 7 years ago

Re-assigning this to the 2.0 milestone.

retrixe commented 7 years ago

Solution: Python scripts for build and compiles, Also, #9

retrixe commented 7 years ago

Actually, this issue is dead thanks to webpack, but now we have #9. Cya

retrixe commented 7 years ago

e6ae304 was supposed to bundle a fix for semantic-ui-css, but an error has displaced that. Wait for next commit. We will incorporate CSS with webpack, at which phase, this is a dead issue.

retrixe commented 7 years ago

ff59e52 Issue done for.

retrixe commented 7 years ago

A newer commit requires the semantic-ui-css to be user upgraded, which is perfect because no need for having breaking changes in the code.