retro-esp32 / RetroESP32

Retro ESP32 is a turbo charged Odroid Go Launcher, Emulator and ROM Manager
Creative Commons Attribution Share Alike 4.0 International
603 stars 93 forks source link

Odd UI Settings screen behavior after selecting color Themes, and then pressing left or right keypad. #48

Closed v666 closed 4 years ago

v666 commented 4 years ago

It looks like Settings screen gets stuck in Color theme setting mode, after you select "THEMES" option and then press left or right to move along the different console emulation options.

Steps to reproduce the behavior:

  1. Start device, RetroESP32 is launched.
  2. "SETTINGS" screen is displayed - Themes, colored icons, volume and brightness options are displayed - Themes is selected by default.
  3. Select "THEMES" by pressing A button -> List of available colors is displayed.
  4. Press keypad right or left - left takes you to PC Engine console, right to NES console.
  5. Go back to Settings screen, by pressing the keypad in the opposite direction you pressed in step 4.
  6. "SETTINGS" screen is displayed - Themes, colored icons, volume and brightness options are displayed - Themes is selected by default.

From this point, depending on the button pressed, different things can happen:

7.A Press keypad down - List of available colors from "THEMES" option is displayed - you can still see the enable colored icons, volume bar and brightness bar options displayed. 7.B Press A Button - The last default color selected in the available colors list will be set as the current Color theme. The list of available colors will be displayed.

Expected behavior / Proposal: I think that after entering into the "THEMES" option, having the list of available colors displayed, user should not be able to move between emulation consoles. Any other button other than UP, DOWN or A, should just cancel the operation and return User to Settings Screen. Or better yet - pressing keypad up or left, will select next color option up in the list, and pressing down or right, will select next color option down in the list - B would return User to the Settings Screen.

32teeth commented 4 years ago

Fixed in v.1.7