retrofax / garglk

Automatically exported from code.google.com/p/garglk
Other
0 stars 0 forks source link

TADS 3 status line always visible, even when turned off #137

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
When the status line banner window in a TADS 3 game is closed, Gargoyle still 
shows a grey bar where the status line would be if it were open. If the status 
line window is closed, it shouldn't be visible at all.

What steps will reproduce the problem?

The attached sample game disables the status line altogether, so the only 
window open should be the main game window. But if you run it in Gargoyle, 
you'll see a grey bar across the top of the window where the status line would 
usually be.

You can also see it in TADS 3 games that use the standard hint menu (e.g. Eric 
Eve's Blighted Isle). When the hint menu is open, the status line is closed and 
replaced with the the hint windows, but in Gargoyle you can still see the blank 
status line above the hint list.

What version of the product are you using? On what operating system?
r487 on Ubuntu Netbook Edition 10.10.

Original issue reported on code.google.com by emily.bo...@gmail.com on 24 Dec 2010 at 12:43

Attachments:

GoogleCodeExporter commented 8 years ago
Can you try the attached patch?

Seems that TADS disables banners by setting them to size zero, instead of 
closing or not opening them at all, so I've reworked the implementation to 
ignore zero sized windows when refreshing the Glk layout.

Original comment by bcressey@gmail.com on 24 Dec 2010 at 4:13

Attachments:

GoogleCodeExporter commented 8 years ago
Works for me! Thanks!

Original comment by emily.bo...@gmail.com on 24 Dec 2010 at 4:27

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Fixed in r489.

Original comment by bcressey@gmail.com on 28 Dec 2010 at 6:58