search

retrohub-org / retrohub

Retrogaming library frontend, built to be a highly customizable platform.
https://retrohub-org.github.io/
MIT License
110 stars 6 forks source link

macOS build fails to load due to missing FFMPEG/godot-videodecoder dependency #358

Closed rsubtil closed 4 months ago

rsubtil commented 4 months ago

(reported on Reddit, v1.0.0)

On macOS, the version string used by Godot on Intel machines is macos.x86_64. The godot-videodecoder dependency uses the macos.universal key instead, thus failing to load the library:

https://github.com/retrohub-org/retrohub/blob/5f22871ed85f9092eacd73cc01d83c70c3d959f0/addons/godot-videodecoder/godot-videodecoder.gdextension#L5-L7

This key doesn't make sense, so we can either get the FFMPEG/godot-videodecoder dependency compiling for arm64 architectures and remove the extra .universal, or restrict this for macos.x86_64 Macs for now.

rsubtil commented 4 months ago

Enabling FFMPEG/godot-videodecoder compilation for arm64 turned out to be easier than expected (https://github.com/retrohub-org/godot-videodecoder/commit/18961a571f9c1544f841b97988681c8873c2ad31), so we should be able to support both. arm64 will be completely untested however, as I don't have access to such machine.