Fix macOS code signing for external dependencies, and support arm64 versions of FFMPEG

retrohub-org / retrohub

Retrogaming library frontend, built to be a highly customizable platform.

https://retrohub-org.github.io/

MIT License

110 stars 6 forks source link

Fix macOS code signing for external dependencies, and support arm64 versions of FFMPEG #359

Closed rsubtil closed 4 months ago

rsubtil commented 4 months ago

Fixes #358

A generic macos.release/debug key is now used, and the FFMPEG/godot-videodecoder dependency is now bundled as a universal dependency. It should also now "in theory" fully support M1 systems, but this needs to be tested and reported by someone else to be working properly.

Since we're already touching CI files, other pending changes were done as well:

Upgrade actions to v4 according to deprecation notices
Added save-always flag on macOS caches, which should massively speed-up the process when CI fails

rsubtil commented 4 months ago

The problem ended up being more structural: the macOS export has been silently failing ever since the introduction of the first .framework dependency (blurhash), failing on the code signature step due to missing Info.plist files.

rsubtil commented 4 months ago

While this fixes issues with blurhash and rcheevos, the FFMPEG library seems to be broken ever since v0.2.0. This won't fix video playback, so it might be time to finally check and work with alternatives, as in the meantime https://github.com/EIRTeam/EIRTeam.FFmpeg/ became a viable choice.