retrooper / packetevents

Precision meets performance—a powerful tool for mastering Minecraft packet manipulation with speed and finesse.
GNU General Public License v3.0
557 stars 151 forks source link

conflict between excellentenchants, oraxen, packetevents and protocollib #1033

Closed thatpris closed 1 month ago

thatpris commented 1 month ago

Describe the bug When BOTH packetevents and protocolib are present, enchants from excellentnenchants cannot be applied to items. Removing either packetevents or protocolib seems to fix the error, so this seems like a conflict between those two.

Software brand Paper 1.21.1

Plugins ExcellentEnchants, Oraxen, PacketEvents and Protocolib.

How To Reproduce

  1. Join with Paper 1.21.1 and all aforementioned plugins
  2. Get an enchantment book from ExcellentEnchants
  3. Apply it to an item in anvil
  4. Bug occurs

Expected behavior The item should be enchanted normally.

Screenshots https://github.com/user-attachments/assets/ab1e492a-9914-4b26-b50c-a50d884675f8

Additional context I have tried asking both ExcellentEnchants and Oraxen, and they have concluded that this is a conflict between packetevents and protocolib.

jtJava commented 1 month ago

What version of PacketEvents did you try?

thatpris commented 1 month ago

What version of PacketEvents did you try?

I am using latest spigot release, but I tested with dev builds and same result

booky10 commented 1 month ago

Seems to be a conflict between packetevents and oraxen, still doesn't work for me when removing protocollib (and removing protocollib usage from oraxen)

booky10 commented 1 month ago

@thatpris after further testing, this issue isn't related to packetevents

ExcellentEnchants and Oraxen don't work together - regardless of whether PacketEvents/ProtocolLib are installed or not

https://github.com/user-attachments/assets/41d54385-5233-4e04-ad1a-2dc9aab428bb

retrooper commented 1 month ago

Thank you @booky10.