retrooper / packetevents

Precision meets performance—a powerful tool for mastering Minecraft packet manipulation with speed and finesse.
GNU General Public License v3.0
557 stars 151 forks source link

Player was null on declare commands packet #1036

Open axeldupuy opened 1 month ago

axeldupuy commented 1 month ago

Describe the bug DeclareCommands packet is sometimes null

Software brand Pufferfish 1.17.1

Plugins Pl-Hide-Pro

How To Reproduce

  1. Join the server.
  2. Error: [Pl-Hide-Pro] Player was null on declare commands packet

Screenshots

Screenshot_1 Screenshot_2 Screenshot_3

retrooper commented 4 weeks ago

Saying that the "DeclareCommands" is null sounds confusing. However, it is possible that the Bukkit player object is null, as PacketEvents has not fetched it, considering the fact that it's instantiated later (compared to when the connection is established). My response would be, either contact me so we can go through specifics, or they can attempt to adapt their code to be less dependent on the Bukkit player in that connection stage. Perhaps, they could also try fetching it using the Bukkit API and the User object's UUID.

smscentras commented 1 week ago

Same problem there, mass flood in console!

[06:01:13] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:01:20] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:01:20] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:01:27] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:01:33] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:01:39] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:01:46] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:01:53] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:02:00] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:02:06] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:02:13] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:02:20] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:02:26] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:02:33] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet