search

retrooper / packetevents

PacketEvents is emerging as a strong contender in the realm of Minecraft packet processing libraries. Designed to simplify packet manipulation while delivering high performance, this powerful tool aims to demystify the complexities of projects utilizing packets.
GNU General Public License v3.0
513 stars 148 forks source link

1.7 player injection is unreliable #167

Closed MWHunter closed 2 years ago

MWHunter commented 2 years ago

Describe the bug Sometimes, on player login, the player's state fails to enter GAME, resulting in none of their packets being processed

To Reproduce Steps to reproduce the behavior: Example:

  1. Login to a spigot 1.7 server and hope for the best that it doesn't inject. I can't consistently reproduce this.

Expected behavior All players who join 1.7 and are playing should be in the game state

Screenshots badstate

About your server (please complete the following information): My test server with only one plugin, grimac. I did not hotswap anything when this error occured.

Additional context Using PacketEvents version https://github.com/retrooper/packetevents/tree/1ea4880dede42be46d4b23cfcc306ac48bb131a2

retrooper commented 2 years ago

What makes you sure this isn’t possible on 1.8?

MWHunter commented 2 years ago

I'm not sure, I just noticed that this has happened a few times out of a few hundred logins on 1.7.

retrooper commented 2 years ago

I'll look into it soon, just really busy in general, and prioritizing some critical things on 2.0. (atleast today)

MWHunter commented 2 years ago

Closing because I was the only one with this issue - and it no longer affects me now that I've moved on to 2.0