search

retrooper / packetevents

Precision meets performance—a powerful tool for mastering Minecraft packet manipulation with speed and finesse.
GNU General Public License v3.0
565 stars 154 forks source link

Add velocity proxy support #208

Closed SkyLicks closed 2 years ago

SkyLicks commented 2 years ago

Is your feature request related to a problem? Please describe. There is no PacketListener API that I know of for Velocity-based Proxies. Plz add <3. I saw you added Bungee support, so Im wondering if you could also add Velocity support?

Describe the solution you'd like Simply extend PacketEvents to be able to hook into Velocity.

Describe alternatives you've considered to solve your solution without us adding this as a feature? So I need to listen to packets to edit a tab completion for an obfuscated plugin in velocity that I didn't write. I've considered directly Modifying my Velocity jar but that's probs a terrible idea.

Additional context Add any other context or screenshots about the feature request here.

retrooper commented 2 years ago

No bungee support/implementation of the API yet

retrooper commented 2 years ago

Eventually I will add Velocity support, course, that's been on my list, I just want to complete the API module, make sure PacketEvents is stable on spigot(Spigot module), potentially push out a first pre-release of 2.0. Then from then on, start working on Velocity/Bungee/etc support. Porting to other platforms (especially if not Spigot) is actually quite easy.

SkyLicks commented 2 years ago

Awesome! Looking forward to it.

retrooper commented 2 years ago

Managed to push out fabric support in a day. Kind of just as a dummy project, Velocity could be coming out quite soon.

retrooper commented 2 years ago

Little reminder that velocity hasn't been forgotten, once some other critical issues on spigot have been fixed and some performance improvements(for all platforms) are dealt with, velocity is on its way.

retrooper commented 2 years ago

First foot steps: https://github.com/retrooper/packetevents/commit/474a2c9e2eb2a455016c87d79e6d6713b30223cf

SkyLicks commented 2 years ago

Good to see!

retrooper commented 2 years ago

I'd say pretty much done!

retrooper commented 2 years ago

Oh yea, have to add. If you want to use it already, check our version-dynamic branch!

retrooper commented 2 years ago

as a dependency, you can do

compileOnly 'com.github.retrooper.packetevents:velocity:version-dnyamic-SNAPSHOT'

I suggest you to use the pre-built JAR via GitHub Actions and not attempt shading yet... https://github.com/retrooper/packetevents/suites/5913317445/artifacts/201829437 It is in that .zip