retrooper / packetevents

PacketEvents is emerging as a strong contender in the realm of Minecraft packet processing libraries. Designed to simplify packet manipulation while delivering high performance, this powerful tool aims to demystify the complexities of projects utilizing packets.
GNU General Public License v3.0
513 stars 148 forks source link

Cancelling packets with ViaVersion broken. #217

Closed MWHunter closed 2 years ago

MWHunter commented 2 years ago

Likely related to https://github.com/retrooper/packetevents/issues/216

Sending a player a PONG packet causes ViaVersion to error and disconnect the user with an out of bounds exception. Many other packets are likely affected but PONG was the easiest to test.

retrooper commented 2 years ago

Can you confirm whether it is reproducable on https://github.com/retrooper/packetevents/commit/86fc6bb452cc5b216334181df49123e358eea06a

retrooper commented 2 years ago

Fixed by https://github.com/retrooper/packetevents/commit/a52a35755b6369db22de08ccdae65c860a22d10c