search

retrooper / packetevents

Precision meets performance—a powerful tool for mastering Minecraft packet manipulation with speed and finesse.
GNU General Public License v3.0
564 stars 151 forks source link

ViaVersion support broken #274

Closed MWHunter closed 2 years ago

MWHunter commented 2 years ago

On the 2.0 branch, ViaVersion support broke today. I can't join the 1.18.1 server from a 1.8 or a 1.18.2 client without a DecoderException. This didn't occur yesterday.

retrooper commented 2 years ago

Is ProtocolLib on the server?

retrooper commented 2 years ago

With Via and packetevents alone, it works.

retrooper commented 2 years ago

https://github.com/ViaVersion/ViaVersion/issues/2839

retrooper commented 2 years ago

We're currently in a sticky situation. ProtocolLib pushed their dev builds, we now only support those. But ViaVersion does not handle these dev builds properly. Well you will get some exceptions in your console due to Via. If you want to go back to a working version of packetevents, using older ProtocolLib with Via support, use https://github.com/retrooper/packetevents/commit/4d77af307c8c4ed36bd691ab5f2447a465823554

retrooper commented 2 years ago

Use https://jitpack.io/#retrooper/packetevents/2.0-4d77af307c-1 from jitpack.io

retrooper commented 2 years ago

Can you test the newest version with https://ci.viaversion.com/job/ViaVersion/lastBuild/ (Latest Via dev build) and https://ci.dmulloy2.net/job/ProtocolLib/ (Latest ProtocolLib dev build) and see if they work?

retrooper commented 2 years ago

All works just fine for me.

MWHunter commented 2 years ago

Broken for me still

MWHunter commented 2 years ago

seems to work now