search

retrooper / packetevents

Precision meets performance—a powerful tool for mastering Minecraft packet manipulation with speed and finesse.
GNU General Public License v3.0
541 stars 152 forks source link

Implement Advancements wrapper #276

Open SkyLicks opened 2 years ago

SkyLicks commented 2 years ago

Is your feature request related to a problem? Please describe. I was trying to send custom Advancement packets (https://wiki.vg/Protocol#Advancements) but I realized there is no packet wrapper for that.

Describe the solution you'd like I am hoping to get a full implementation of the Advancement packets.

Describe alternatives you've considered to solve your solution without us adding this as a feature? I've tried using PLib but it looks like, PLibs implementation of Advancement packets might only be partial.

Additional context My goal was to basically have a command that will display custom advancement text. I already have a working sample using NMS code, but for version compatibility, I want to move away from NMS.

MWHunter commented 2 years ago

want to note for anyone implementing this into PacketEvents that MCProtocolLib has a implementation that we can copy over: https://github.com/GeyserMC/MCProtocolLib/blob/master/src/main/java/com/github/steveice10/mc/protocol/packet/ingame/clientbound/ClientboundUpdateAdvancementsPacket.java

NoJokeFNA commented 2 years ago

I've already started it here: https://github.com/NoJokeFNA/packetevents/commit/27acc38d464fec5904a75d0a157e6aa736d223e5 but it's not done yet