search

retrooper / packetevents

Precision meets performance—a powerful tool for mastering Minecraft packet manipulation with speed and finesse.
GNU General Public License v3.0
541 stars 152 forks source link

Chunk_Data packet broken on 1.18 #288

Closed MWHunter closed 2 years ago

MWHunter commented 2 years ago

[18:16:02 INFO]: [PacketEventsTest] [STDOUT] Sending CHUNK_DATA [18:16:02 INFO]: DefineOutside lost connection: Internal Exception: io.netty.handler.codec.EncoderException: java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0

retrooper commented 2 years ago

Try reproduce it again, thing is on older commits than https://github.com/retrooper/packetevents/commit/a9fb68223a643c8bdc497f47b56e50f07ec7d916 exceptions in our internal api were sort of surpressed. Now you should get a detailed stacktrace hopefully.

retrooper commented 2 years ago

And https://github.com/retrooper/packetevents/commit/8dfbda5e35cc8de633440b1ec58d0289d9937ba9 can help produce more meaningful exceptions for issues like these. Update to that.

retrooper commented 2 years ago

You have some indexoutofboundsexception in the chunk data wrapper, update to the mentioned commit to find out what line.

NoJokeFNA commented 2 years ago

@MWHunter Any news on this? 🤔

MWHunter commented 2 years ago

Fixed by reverting 5bf2daa7 so don't blame me for having the wrapper be broken for 3 months.

Retrooper pushed a commit that broke this wrapper... @retrooper stop pushing without testing your changes.