retrooper / packetevents

Precision meets performance—a powerful tool for mastering Minecraft packet manipulation with speed and finesse.
GNU General Public License v3.0
541 stars 152 forks source link

[BUG REPORT] WrapperPlayServerMultiBlockChange causes players to be kicked #292

Closed XReioX closed 2 years ago

XReioX commented 2 years ago

Describe the bug So when you read a multiblockchange packet, it will kick you with EncoderException: NPE

To Reproduce Steps to reproduce the behavior:

  1. Start up a 1.8.8 server
  2. Log into 1.8.8 server with a 1.8.9 client
  3. Have a plugin ready what is reading the multiblockchange wrapper
  4. Just log in, and walk around and try breaking block etc

Expected behavior I expect that it will not kick me, and instead give me the data requested.

Screenshots None

About your server (please complete the following information):

Additional context None

retrooper commented 2 years ago

Was able to reproduce. Will be looked into.

retrooper commented 2 years ago

Fixed by https://github.com/retrooper/packetevents/commit/a9fb68223a643c8bdc497f47b56e50f07ec7d916

retrooper commented 2 years ago

And https://github.com/retrooper/packetevents/commit/8dfbda5e35cc8de633440b1ec58d0289d9937ba9 has some better patches for catching exceptions