search

retrooper / packetevents

PacketEvents is emerging as a strong contender in the realm of Minecraft packet processing libraries. Designed to simplify packet manipulation while delivering high performance, this powerful tool aims to demystify the complexities of projects utilizing packets.
GNU General Public License v3.0
510 stars 146 forks source link

FEATURE REQUEST: Add NachoSpigot support #307

Closed zhusun890 closed 2 years ago

zhusun890 commented 2 years ago

Is your feature request related to a problem? Please describe. When somebody joins a server with NachoSpigot and on pre-login state, it will be disconnected by reason "Exception Connecting: NativeIOException : readAddress(...) failed: Connection reset by peer"

Describe the solution you'd like Add support for NachoSpigot

Describe alternatives you've considered to solve your solution without us adding this as a feature? A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

amnoah commented 2 years ago

Solution: don't use Spigot forks that mess with random stuff in order to make minuscule optimizations.

(ofc Retrooper/DefineOutside decide on outcomes for this stuff)

ghost commented 2 years ago

Not a PacketEvents issue. Issue tracked in CobbleSword/NachoSpigot#356.

retrooper commented 2 years ago

Tomorrow I will look into it, but something questionable is this works on any other server software.

retrooper commented 2 years ago

NachoSpigot now works. We recently added a Paper injector, which is more efficient on Paper software and luckily works on Nacho. https://github.com/retrooper/packetevents/commit/f9136dbf42158a924ebc29456b5e530afe5b4ff8