search

retrooper / packetevents

Precision meets performance—a powerful tool for mastering Minecraft packet manipulation with speed and finesse.
GNU General Public License v3.0
563 stars 151 forks source link

I removed the client version cache #323

Closed MWHunter closed 2 years ago

MWHunter commented 2 years ago

It was memory leaking due to using Integers as keys. It was 17k in size after a minute. This cache should be re-added.

MWHunter commented 2 years ago

additionally, it needs to be a concurrent hashmap if we use a cache in this way.

MWHunter commented 2 years ago

Fixed in https://github.com/retrooper/packetevents/commit/5d1b6a7d2acc011b205a8c1eead4b5a75e63f0e5 because a hashmap seems overkill for what we were trying to do.