retrooper / packetevents

PacketEvents is emerging as a strong contender in the realm of Minecraft packet processing libraries. Designed to simplify packet manipulation while delivering high performance, this powerful tool aims to demystify the complexities of projects utilizing packets.
GNU General Public License v3.0
513 stars 148 forks source link

Failed to inject... Please rejoin! #338

Closed Loudbooks closed 2 years ago

Loudbooks commented 2 years ago

I'm getting this error when reloading my plugin with PlugmanX. Plugin list attached. image image

PacketEvents Version: 2.0-SNAPSHOT Server Version: 1.18.2

Really annoying!

Thanks :D

MWHunter commented 2 years ago

what packetevents commit/version are you on?

Loudbooks commented 2 years ago

what packetevents commit/version are you on?

@MWHunter Forgot to mention: I have 2.0-SNAPSHOT in my pom.xml

MWHunter commented 2 years ago

and what server version are you on?

Loudbooks commented 2 years ago

and what server version are you on?

@MWHunter 1.18.2

NoJokeFNA commented 2 years ago

You are just getting kicked if you reload the plugin while you are on the network, so you simply have to rejoin. In general, just don't reload stuff and just restart the server instead, causes less issues.

MWHunter commented 2 years ago

I think I could have broken something by avoiding injection into existing pipelines to avoid injecting before viaversion on 1.8.

Loudbooks commented 2 years ago

You are just getting kicked if you reload the plugin while you are on the network, so you simply have to rejoin. In general, just don't reload stuff and just restart the server instead, causes less issues.

I guess, but it's really difficult to do that during testing.

MWHunter commented 2 years ago

You should attach a debugger and hot swap, then you won't have to constantly reload. With something like DCEVM, you barely have to reload at all.

Loudbooks commented 2 years ago

That went way over my head.

MWHunter commented 2 years ago

Fixed by https://github.com/retrooper/packetevents/commit/511b331735b275abc29ce7540736bd94c5b1c32f

retrooper commented 2 years ago

Fixed by https://github.com/retrooper/packetevents/commit/6bf70f5b472c82e156416f3a96f7636f01333841