search

retrooper / packetevents

Precision meets performance—a powerful tool for mastering Minecraft packet manipulation with speed and finesse.
GNU General Public License v3.0
544 stars 151 forks source link

Unable to join server #440

Closed scarfacered closed 2 years ago

scarfacered commented 2 years ago

Describe the bug https://pastebin.com/raw/TwXTj5qX

Software brand Paper 1.19

Plugins ViaVersion, ViaBackwards

How To Reproduce Connect to 1.19 server

scarfacered commented 2 years ago

I believe this caused it https://github.com/retrooper/packetevents/commit/5f49f63e8fad548ebeb5ef7a58a2bacb1d7644c5#diff-6e61ed83ab8d18aa7c13046c2cb4db8354217fb1ef7b1745b5f4f8227cbef7e9R55

NoJokeFNA commented 2 years ago

The size is complete different so it wouldn't make that much sense

scarfacered commented 2 years ago

The size is complete different so it wouldn't make that much sense

https://github.com/retrooper/packetevents/blob/5f49f63e8fad548ebeb5ef7a58a2bacb1d7644c5/api/src/main/java/com/github/retrooper/packetevents/wrapper/PacketWrapper.java#L368

It's multiplied by 4 here? 255 * 4 = 1020, which is what you're seeing in that error log. I'm not sure how my serverAddress is longer than 255 letters, though. It's behind Velocity? I'd be curious to see the string it's trying to parse.

retrooper commented 2 years ago

So is this issue resolved?

retrooper commented 2 years ago

I'm gonna mark it as solved then...

scarfacered commented 2 years ago

Yes! Sorry