search

retrooper / packetevents

PacketEvents is emerging as a strong contender in the realm of Minecraft packet processing libraries. Designed to simplify packet manipulation while delivering high performance, this powerful tool aims to demystify the complexities of projects utilizing packets.
GNU General Public License v3.0
511 stars 146 forks source link

Latest ViaVersion breaks grabbing user client version #680

Closed KaspianDev closed 5 months ago

KaspianDev commented 7 months ago

Describe the bug Since probably this or a bit earlier build of via PE errors when trying to get the user version with following message: Unable to grab ViaVersion client version for player!

Software brand Paper 1.20.4

Plugins AntiPopup (shades PE), ViaVersion

How To Reproduce

  1. Use User#getClientVersion method
  2. The message appears

PS: Might be a good idea to use PacketEvent's version grabber as fallback to prevent these in future

jordoncodes commented 6 months ago

Describe the bug Since probably this or a bit earlier build of via PE errors when trying to get the user version with following message: Unable to grab ViaVersion client version for player!

Software brand Paper 1.20.4

Plugins AntiPopup (shades PE), ViaVersion

How To Reproduce

  1. Use User#getClientVersion method
  2. The message appears

PS: Might be a good idea to use PacketEvent's version grabber as fallback to prevent these in future

try using the latest ViaVersion snapshot from hangar with PE 2.2.1, this seems to work for me.

ArionOwO commented 6 months ago

I'm also experiencing the "Unable to grab ViaVersion client version for player!" spam with the latest dev build of viaversion/viabackwards, also i've tried 1.20.2 and 1.20.4 latest versions of paper.

retrooper commented 5 months ago

Fixed in https://github.com/retrooper/packetevents/commit/5502c4a434d1f2ddeea310b306dfef43aa44a33f