retrooper / packetevents

Precision meets performance—a powerful tool for mastering Minecraft packet manipulation with speed and finesse.
GNU General Public License v3.0
542 stars 151 forks source link

because "enchantment" is null #963

Closed dol4iua closed 2 months ago

dol4iua commented 2 months ago

Describe the bug [21:24:49] [Server thread/INFO]: Endemic_345[/IP:PORT] logged in with entity id 1637 at ([world]-21328.30000001192, 67.0, 17681.69999998808) [21:24:49] [Server thread/INFO]: Endemic_345 lost connection: Internal Exception: io.netty.handler.codec.EncoderException: java.lang.NullPointerException: Cannot invoke "com.github.retrooper.packetevents.protocol.item.enchantment.type.EnchantmentType.getId(com.github.retrooper.packetevents.protocol.player.ClientVersion)" because "enchantment" is null Kick players with this messegs. After i update https://www.spigotmc.org/resources/excellentenchants-%E2%AD%90-75-vanilla-like-enchantments.61693/ to lates version. (on version 4.1.0 all works)

Kick all playes.

Software brand Please let us know what software you are using. Version of PE- packetevents-spigot-2.5.0-SNAPSHOT Core - PurPur 1.21.1 - purpur-1.21.1-2291

Plugins Paper Plugins: (1):

How To Reproduce After i update https://www.spigotmc.org/resources/excellentenchants-%E2%AD%90-75-vanilla-like-enchantments.61693/ to lates version. (on version 4.1.0 all works)

booky10 commented 2 months ago

Are you using the latest packetevents build?

dol4iua commented 2 months ago

image

Z3r0xh commented 2 months ago

image

I'm using the latest dev build, every day I check the builds in jenkins and download them. But I keep getting the same error.

thesquidghost commented 2 months ago
Screenshot 2024-08-23 at 1 13 33 PM

just wanted to report that I also am getting this after updating a handful of plugins.

mahon91 commented 2 months ago

Same problem here : image

mahon91 commented 2 months ago

Here are a few clarifications:

When I find an enchanted book in a chest, if I try to open the chest, I get kicked from the server.

If I put an enchanted book in my inventory, it's even worse—I can no longer rejoin the server.

MrMcyeet commented 2 months ago

I'm seeing this, too, when using either ecoenchants or excellent enchants

Keviro commented 2 months ago

This still happens with version 2.5.0+e105770dd-SNAPSHOT

[packetevents] You are running a development build of PacketEvents. Your build: (2.5.0+e105770dd-SNAPSHOT) | Latest release: (2.4.0)

MeoNguOfficial commented 2 months ago

I have same error too

LadyHaley commented 2 months ago

I am also getting the same error [15:30:17 INFO]: LadyHaley lost connection: Internal Exception: io.netty.handler.codec.EncoderException: java.lang.NullPointerException: Cannot invoke "com.github.retrooper.packetevents.protocol.item.enchantment.type.EnchantmentType.getId(com.github.retrooper.packetevents.protocol.player.ClientVersion)" because "enchantment" is null

booky10 commented 2 months ago

@thesquidghost @mahon91 @MrMcyeet @MeoNguOfficial @LadyHaley Please ensure you all are using the latest build of packetevents, this issue should not be related to problems with ecoenchants


@dol4iua @Z3r0xh @MrMcyeet please test if #972 fixes your problems download to packetevents build: https://github.com/retrooper/packetevents/actions/runs/10613644385/artifacts/1869331529

LadyHaley commented 2 months ago

I looked into why I even had the plugin, the libsdisguise dev build seems to be downloading what its labeling as packetevents-spigot-2.5.0-SNAPSHOT if that helps with the influx of entries at all Also for the record, in case it matters, I am not using EcoEnchants, I am using Excellent Enchants

booky10 commented 2 months ago

use the latest build from jenkins, this issue should be fixed