retrooper / packetevents

Precision meets performance—a powerful tool for mastering Minecraft packet manipulation with speed and finesse.
GNU General Public License v3.0
557 stars 151 forks source link

Add wrapper for BossBar packet #990

Closed Elikill58 closed 2 months ago

Elikill58 commented 2 months ago

This PR add a wrapper for BOSS_BAR packet.

I pre-answer few questions:

I suggest you to Squash and merge. That's would be perfect.

booky10 commented 2 months ago

Using adventure's bossbar classes would be a lot nicer to work with

Elikill58 commented 2 months ago

Using adventure's bossbar classes would be a lot nicer to work with

That's can be difficult as only one action has informations about the full bossbar, else it's only a part of it. Should I add something that is a partial bossbar, return null when not full or do nothing?

booky10 commented 2 months ago

I meant using Bossbar.Color, etc. Not constructing adventure bossbar objects

Elikill58 commented 2 months ago

Oh yes, it's good idea. I just made changes about this :)

booky10 commented 2 months ago

could you also parse the flags sent in the packet?

Elikill58 commented 2 months ago

I'll check. It will require more testing as it's more versions depending

Elikill58 commented 2 months ago

That's it! :) (Note: please don't forget to squash, it's better)

retrooper commented 2 months ago

Thanks for your PR.