zoggins
commented
3 years ago For the L, R, start, select can’t you just define buttons in your skin with the same location and size as x, y, z? You can also define discrete button pushes from the analog stick:
This says that if x goes negative by at least .01 the button defined as “x-“ is shown.
You shouldn’t need a code change to do any of this. If I could get a copy of your skin I might be able to help more.
From: q---- @.> Sent: Friday, April 30, 2021 13:10 To: retrospy/RetroSpy @.> Cc: Subscribed @.***> Subject: [retrospy/RetroSpy] Better input display for Game Boy Player (#183)
When using a GBP with a regular Game Cube controller, I find it to be somewhat overkill to display all inputs on the gc controller, especially since the analog stick gets mapped to d-pad, plus buttons are sometimes mapped to the same thing.
I made a simple addition just above the return statement to RetroSpy/Readers/GameCube.cs to address this:
state.SetButton("gbp_up", ReadStick(SignalTool.ReadByte(packet, BUTTONS.Length + 8)) > 0.5f || packet[12] != 0x00);
state.SetButton("gbp_down", ReadStick(SignalTool.ReadByte(packet, BUTTONS.Length + 8)) < -0.5f || packet[13] != 0x00);
state.SetButton("gbp_right", ReadStick(SignalTool.ReadByte(packet, BUTTONS.Length)) < -0.5f || packet[14] != 0x00);
state.SetButton("gbp_left", ReadStick(SignalTool.ReadByte(packet, BUTTONS.Length)) > 0.5f || packet[15] != 0x00);
state.SetButton("gbi_start", packet[3] != 0x00 || packet[5] != 0x00);
state.SetButton("gbi_select", packet[4] != 0x00 || packet[11] != 0x00);
state.SetButton("gbp_l", ReadTrigger(SignalTool.ReadByte(packet, BUTTONS.Length + 32)) > 0.5f);
state.SetButton("gbp_r", ReadTrigger(SignalTool.ReadByte(packet, BUTTONS.Length + 40)) > 0.5f);
I'm using GBI software to interface with my GBP, which maps both start and x to gameboy start and y and z to gameboy select, which is different than the default. Thus, to cover more use cases, it may be necessary to add more buttons, if this is the best method to add this functionality.
Things I'm unsure of:
- whether the exact boundary for when gbp receives an up input on the analog stick is at 0.5f
- same for other directions on the analog stick and for the triggers
- whether this is the best method for addressing mapping, or if there is some easy way that the user could be allowed to configure their button mappings to fully cover their use case
- whether there was already a way to do this with a carefully constructed skin
- simply assigning the same image with same location to multiple buttons would likely handle the many-to-one button mappings, but I didn't see an obvious way to translate stick position to a button press reliably
- whether this concept would be useful for other controller types
As mentioned, I have a working build with the changes I listed above, so this isn't high priority for me, but it took a bit of looking to figure out, so it may be good to add for future users depending on whether you feel it's a good fit.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/retrospy/RetroSpy/issues/183, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE2CEVXXZJ73XOZWZN5QSJLTLME7ZANCNFSM435L7PEQ.
q----
When using a GBP with a regular Game Cube controller, I find it to be somewhat overkill to display all inputs on the gc controller, especially since the analog stick gets mapped to d-pad, plus buttons are sometimes mapped to the same thing.
I made a simple addition just above the return statement to RetroSpy/Readers/GameCube.cs to address this:
I'm using GBI software to interface with my GBP, which maps both start and x to gameboy start and y and z to gameboy select, which is different than the default. Thus, to cover more use cases, it may be necessary to add more buttons, if this is the best method to add this functionality.
Things I'm unsure of:
0.5fAs mentioned, I have a working build with the changes I listed above, so this isn't high priority for me, but it took a bit of looking to figure out, so it may be good to add for future users depending on whether you feel it's a good fit.