retrospy / RetroSpy

Live controller viewer for Nintendo consoles as well as many other retro consoles and computers. Includes viewer application for Windows, and Arduino sketch for hardware interface.
https://retro-spy.com
GNU General Public License v3.0
145 stars 22 forks source link

remove broken skins #192

Closed MrGamy closed 2 years ago

MrGamy commented 3 years ago

Some skins seem to have stopped working for a while now and should be repaired or removed since they are causing an error message when starting retrospy:

generic-hitbox-brookeps3ps4tomdsc-ds4-md6b
generic-hitbox-brooksc-ds4-md6
generic-hitbox-ds4
generic-hitbox-xb360
generic-pattonboxdigital-brookeps3ps4tomdsc-ds4-md6b
generic-pattonboxdigital-brooksc-ds4-md6
generic-pattonboxdigital-ds4

brokenskins

zoggins commented 3 years ago

In the Help -> About screen what version does it say. The precision keyword is only supported from 4.1 and up. Not sure how you got the new skins, but I am betting your .exe is (for some reason) below 4.1.

From: MrGamy @.> Sent: Thursday, July 29, 2021 04:18 To: retrospy/RetroSpy @.> Cc: Subscribed @.***> Subject: [retrospy/RetroSpy] remove broken skins (#192)

Some skins seem to have stopped working for a while now and should be repaired or removed since they are causing an error message when starting retrospy:

generic-hitbox-brookeps3ps4tomdsc-ds4-md6b

generic-hitbox-brooksc-ds4-md6

generic-hitbox-ds4

generic-hitbox-xb360

generic-pattonboxdigital-brookeps3ps4tomdsc-ds4-md6b

generic-pattonboxdigital-brooksc-ds4-md6

generic-pattonboxdigital-ds4

[brokenskins]https://user-images.githubusercontent.com/8639512/127480649-5e3e5053-1807-44b1-a21a-e3f9741baa15.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/retrospy/RetroSpy/issues/192, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE2CEVSYKGGKAJNFOYNSQILT2E2E7ANCNFSM5BGIA74A.

MrGamy commented 3 years ago

I am running Version 4.2.3.0

about

zoggins commented 3 years ago

Hmmm, that is unexpected. I will see what I can find, but I can’t repro the error.

From: MrGamy @.> Sent: Thursday, July 29, 2021 15:06 To: retrospy/RetroSpy @.> Cc: Christopher Mallery @.>; Comment @.> Subject: Re: [retrospy/RetroSpy] remove broken skins (#192)

I am running Version 4.2.3.0 Build Timestamp is 30/07/2021 00:03:12 [about]https://user-images.githubusercontent.com/8639512/127571809-95f7378d-7c90-4661-812a-6deb3db55fd3.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/retrospy/RetroSpy/issues/192#issuecomment-889490979, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE2CEVSMK6IEGSM2AVHKCFTT2HGFBANCNFSM5BGIA74A.

zoggins commented 3 years ago

Did you delete the skins? If you didn’t delete them could I get a copy of one of them?

From: Christopher Mallery Sent: Thursday, July 29, 2021 15:52 To: retrospy/RetroSpy @.>; retrospy/RetroSpy @.> Cc: Comment @.***> Subject: RE: [retrospy/RetroSpy] remove broken skins (#192)

Hmmm, that is unexpected. I will see what I can find, but I can’t repro the error.

From: MrGamy @.**@.>> Sent: Thursday, July 29, 2021 15:06 To: retrospy/RetroSpy @.**@.>> Cc: Christopher Mallery @.**@.>>; Comment @.**@.>> Subject: Re: [retrospy/RetroSpy] remove broken skins (#192)

I am running Version 4.2.3.0 Build Timestamp is 30/07/2021 00:03:12 [about]https://user-images.githubusercontent.com/8639512/127571809-95f7378d-7c90-4661-812a-6deb3db55fd3.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/retrospy/RetroSpy/issues/192#issuecomment-889490979, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE2CEVSMK6IEGSM2AVHKCFTT2HGFBANCNFSM5BGIA74A.

MrGamy commented 3 years ago

here you go - extracted one of the skins but added my whole retrospy folder for good measure. https://drive.google.com/file/d/1v7cq3xjwguG0pBGLidSd0M-r4AY1Hcf3/view?usp=sharing

MrGamy commented 3 years ago

Quick update - I just downloaded the current retrospy-release.zip and opened that fresh install: same error message. precision seems not to work

zoggins commented 3 years ago

Well to add to the confusion I just downloaded your zipped up RetroSpy directory and it starts up fine with the skin in the skin folder.

From: MrGamy @.> Sent: Monday, August 2, 2021 13:17 To: retrospy/RetroSpy @.> Cc: Christopher Mallery @.>; Comment @.> Subject: Re: [retrospy/RetroSpy] remove broken skins (#192)

Quick update - I just downloaded the current retrospy-release.zip and opened that fresh install: same error message. precision seems not to work

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/retrospy/RetroSpy/issues/192#issuecomment-891304720, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE2CEVU6Z5ALBPXCXNGTDATT234MPANCNFSM5BGIA74A.

MrGamy commented 3 years ago

haha, awesome! That doesn't really help with finding out whats wrong though. D:

zoggins commented 2 years ago

still having the problem?

zoggins commented 2 years ago

closing from inactivity. Feel free to repopen if necessary.

MrGamy commented 2 years ago

sorry for not responding earlier - yes, this issue is still persistent, I have not checked the nightly build though. Might there be any dependency I need to have installed on windows?

zoggins commented 2 years ago

Another person is having this issue.

zoggins commented 2 years ago

What language is your Windows set to? Is it English or something else?

MrGamy commented 2 years ago

My Windows is set to English currently. Secondary Language would be German

zoggins commented 2 years ago

When you get a chance could you try this build: https://github.com/retrospy/RetroSpy/releases/tag/diag1

zoggins commented 2 years ago

Finally solved this. It had to do with locale settings expecting a ',' instead of '.' in float numbers.