search

retrouser955 / discord-player-youtubei

Super charging your bot. dpy is a tiny extractor module to test the validity of youtubei.js in discord-player version 7.
https://discord-player.js.org
Creative Commons Zero v1.0 Universal
25 stars 8 forks source link

Entirely remove the cache system from discord-player-youtubei #10

Closed retrouser955 closed 4 months ago

retrouser955 commented 4 months ago

TLDR;

The current cache system provided by youtubei.js is unreliable and causes a lot of issues.

Why remove the cache?

youtubei.js seems to like to break due to cache issues. In version 1.0.9, we temporarily had to use the ANDROID platform to get streams. This is due to a problem with the cache. In version 1.1.4, playlist URLs stopped working. Again, due to cache issues. On top of this, discord-player already provide a non-persistent cache for use which makes the cache implementation of youtubei.js's cache entirely useless.

Conclusion

Due to having faced issues, I am planning to remove the cache in this module that is from youtubei.js.

febkosq8 commented 4 months ago

Given that this package is supposed to work with discord-player anyway. Agree that it makes sense to use cache system that discord-player package implements.

retrouser955 commented 4 months ago

Cache system is disabled by default as of 1.1.5 and will be entirely removed by 1.2.x