search

retsamknaps / Aktie

Anonymous file sharing. Distributed forums.
22 stars 6 forks source link

Fix typos in README.md and add queries to aktie.index.Index #65

Open descale opened 7 years ago

descale commented 7 years ago

Small test contribution fixing typos and adding new queries.

retsamknaps commented 7 years ago

Thank you for the pull request. Not sure of the benefit of removing the identity cache. We hit identity data hard. Having it cached in memory should be a nice performance benefit, but honestly we haven't measured it. Do you have some metrics or further explanation?

descale commented 7 years ago

There is a nice but very big patch posted on Aktie for separating node and gui in code base. Some of the code also worked for things I experimented with, but it is likely too big to be merged in one step. Should be done in small steps. Moving the identity cache to the index is just one of a number of things that would need to be adapted. Just selected this commit for this small test pull request. I do not think it would impact performance. In my opinion, the point is the database lookup that would happen otherwise.