search

retupmoca / P6-Net-AMQP

MIT License
6 stars 4 forks source link

Fix for deprecations #2

Closed jonathanstowe closed 9 years ago

jonathanstowe commented 9 years ago

Hi, using class/role/module in the semicolon form recently became deprecated in rakudo so one of these commits fixes that.

Also I noticed that the tests were exiting without doing the skip if the connection failed so I've added a try to the await.

However there is another problem which I am still hunting down as it appears that the behaviour of IO::Socket::Async has changed between rakudo 2015.04 and rakudo 2015.05 which appears to cause the bytes_supply to quit before the response is received. If I find the cause I'll raise another PR.

jonathanstowe commented 9 years ago

The last commit that I added fixes the problem I mis-diagnosed as with IO::Socket::Async - the actual problem was that ::Method.Buf was completing and the supply was being quit before the strart-ok frame was sent. This was probably due to the way that the zip operator worked.

Now the last thing I am chasing down is the channel.flow isn't completely implemented on the version of RMQ that I have so I get a

Error on AMQP connection <0.5377.0> (127.0.0.1:55602 -> 127.0.0.1:5672, vhost: '/', user: 'guest', state: running), channel 1: {amqp_error,not_implemented,"active=false",'channel.flow'}

And because this isn't handled the t/05-channel test is hanging.

retupmoca commented 9 years ago

I'm not currently doing a lot of active development on this, or using it anywhere - let me know if you want a commitbit!

jonathanstowe commented 9 years ago

Hi, I've just sent another PR to skip the flow() tests for the time being.

I'm only really just periodically testing the module to make sure it still works as I have lots of yaks to shave before I get to actually using it in anything ;-)

But if you're up for it I'll take commit :)

retupmoca commented 9 years ago

PR merged, commitbit given. Have fun!