retypeapp / retype

Retype is an ✨ ultra-high-performance✨ static site generator that builds a website based on simple text files.
https://retype.com
Other
1.06k stars 204 forks source link

The bottom padding/margin is missing when the ToC takes the full height of the page #632

Closed patricklafrance closed 1 year ago

patricklafrance commented 1 year ago

The bottom padding/margin is missing when the ToC takes the full height of the page:

image

The same issue exists on the Retype documentation website: https://retype.com/configuration/project/#url

Thank you,

Patrick

geoffreymcgill commented 1 year ago

I don't really see this as an issue. Do you feel there should be additional padding just at the bottom of the ToC column when the page content is scrolled to the bottom? or, more padding below each item no matter what position they are in the menu? And only more padding on the active items (blue items), or all menu items?

patricklafrance commented 1 year ago

Sorry my reporting is confusing. I feel there should be additional padding just at the bottom of the ToC column when the page content is scrolled to the bottom.

Something like this:

image

patricklafrance commented 1 year ago

Sorry for commenting again on this very minor issue 😆

IMO, the bottom padding should be similar for both the sidebar menu and the ToC. Currently the sidebar bottom padding makes sense so the ToC bottom padding should probably use the same value as the sidebar bottom padding:

image

geoffreymcgill commented 1 year ago

Thanks for pointing this out. I will adjust and the fix will be included in the next release of Retype.

geoffreymcgill commented 1 year ago

The same padding has been added to the bottom of the ToC and will be included in the upcoming Retype v3.5.0 release.

patricklafrance commented 1 year ago

@geoffreymcgill I can confirm that the last item of the ToC is now spaced from the bottom.

However, it would be better to update the spacing of the container including the scrollbar rather than the last item of the ToC. Here's what I get with v3.5.0:

image

If the container of the scrollbar would be spaced instead of the last item of the ToC, that would be similar to the left sidebar:

image

geoffreymcgill commented 1 year ago

The little bit of margin-bottom under the left tree nav has been removed. The change will be included in the next release of Retype.