search

retyui / react-native-confirmation-code-field

A react-native confirmation code field compatible with iOS, Android and Web
MIT License
1.07k stars 125 forks source link

#192 - add custom input comp props #193

Closed muslumsezgin closed 2 years ago

muslumsezgin commented 2 years ago

Hello there, this commits adds a custom text input as a param with the default component as fallback value. Concern was to pass a custom text input comp for dynamic usage.

retyui commented 2 years ago

Concern was to pass a custom text input comp for dynamic usage.

@muslumsezgin do you know that this text input actually transparent? is it make sense to customise it?

muslumsezgin commented 2 years ago

Concern was to pass a custom text input comp for dynamic usage.

@muslumsezgin do you know that this text input actually transparent? is it make sense to customise it?

@retyui When used in popups/modals, text input resizes itself on focus and requests that you need to use its wrapped component so it will calculate and fit the size.

as ref: https://gorhom.github.io/react-native-bottom-sheet/keyboard-handling

retyui commented 2 years ago

Oh, no I understand use-case!

Please fix a TS error and I will merge & release it

muslumsezgin commented 2 years ago

Oh, no I understand use-case!

Please fix a TS error and I will merge & release it

@retyui Do you have any suggestions on how can I get around the error I’m getting as I don’t have much experience with typescript?

retyui commented 2 years ago

Released: 7.3.0

diff: 7.2.0...7.3.0