search

retyui / react-quick-pinch-zoom

A react component that providing multi-touch gestures for zooming and dragging on any DOM element.
https://react-quick-pinch-zoom.netlify.app/
310 stars 47 forks source link

Should tslib be a dependency? #74

Closed tf closed 1 year ago

tf commented 1 year ago

I'm seeing Webpack dependency resolution errors that tslib is missing. I did not notice this during development since I had other packages that depended on tslib in my dev dependencies. During deploy it failed, though.

This library uses importHelpers: true, but declares tslib only as a peerDependency. Others (e.g., [1], [2]) seem to declare it as dependency as well. Alternatively, I think, it would need to be mentioned in the install instructions in the README.

Let me know what you think and I can create PR.

[1] https://github.com/dojo/meta/issues/226 [2] https://angular.io/guide/migration-update-libraries-tslib

retyui commented 1 year ago

Good catch, could you please open PR to fix it?

retyui commented 1 year ago

Fixed in 4.9.0

diff: 4.8.0...4.9.0