search

reu / omniauth-steam

Steam authentication strategy for OmniAuth
93 stars 38 forks source link

get friendlist from steam #7

Closed paulohp closed 11 years ago

reu commented 11 years ago

Hi Paulo,

Thanks for the contribution! Unfortunately I can't accept it in the exact way it is implemented. The reason is as this is mainly an authentication library (and not a Steam WEB API client), it doesn't really make sense to return every possible information we can gather from an user. One of the Omniauth guidelines is to not make extra HTTP requests to fetch additional user information, as these information may have no use for the majority of the people who are just using the library for authentication purposes. By issuing an additional HTTP request to fetch the user's friend list automatically, we are violating this guideline.

What in my opinion does make sense, is to include the friend list URL in the user info's "urls" section. This way you will be able to (manually) issue an extra HTTP request only if you are willing to fetch the user's friend list (and not forcing it every time an user successfully authenticates).

Anyway, if you are looking for a fully featured Steam Web API client library, I suggest you to take a look at Steam Condenser.

reu commented 11 years ago

I am closing this, as I just added the friend list support via the URL in user info's url section I mentioned above https://github.com/reu/omniauth-steam/commit/48681d491b97096ad05cfd4bb92c38556aaaf09a.